starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-02-06 00:59:39 +03:00
Code Issues 784 Packages Projects Releases 10 Wiki Activity

[PR #3580] [MERGED] TinyMCE6 update #6230

New Issue
Closed
opened 2026-02-05 10:27:18 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 10:27:18 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/3580
Author: @ssddanbrown
Created: 7/17/2022
Status: ✅ Merged
Merged: 7/23/2022
Merged by: @ssddanbrown

Base: development ← Head: tinymce6

📝 Commits (7)

  • c519f70 Started upgrade to TinyMCE6, Untested
  • cd929b2 Made a bunch of tinymce 6 upgrade fixes
  • 6a6f000 Added back in image options context toolbar item
  • a9ee2e6 Removed toolbar dialog background line
  • f86bb27 Ensured wysiwyg details contents are wrapped in block elements
  • 8176ca1 Fixed blue wyswiyg toolbar in dark mode
  • aad2238 Enabled modern tinymce table features

📊 Changes

90 files changed (+1201 additions, -2138 deletions)

View changed files

➕ public/libs/tinymce/custom-changes.md (+17 -0)
📝 public/libs/tinymce/icons/default/icons.min.js (+1 -1)
📝 public/libs/tinymce/license.txt (+21 -504)
➕ public/libs/tinymce/models/dom/model.min.js (+4 -0)
📝 public/libs/tinymce/plugins/advlist/plugin.min.js (+2 -7)
📝 public/libs/tinymce/plugins/anchor/plugin.min.js (+2 -7)
📝 public/libs/tinymce/plugins/autolink/plugin.min.js (+2 -7)
📝 public/libs/tinymce/plugins/autoresize/plugin.min.js (+2 -7)
📝 public/libs/tinymce/plugins/autosave/plugin.min.js (+2 -7)
➖ public/libs/tinymce/plugins/bbcode/plugin.min.js (+0 -9)
📝 public/libs/tinymce/plugins/charmap/plugin.min.js (+2 -7)
📝 public/libs/tinymce/plugins/code/plugin.min.js (+2 -7)
📝 public/libs/tinymce/plugins/codesample/plugin.min.js (+2 -7)
➖ public/libs/tinymce/plugins/colorpicker/plugin.min.js (+0 -9)
➖ public/libs/tinymce/plugins/contextmenu/plugin.min.js (+0 -9)
📝 public/libs/tinymce/plugins/directionality/plugin.min.js (+2 -7)
➖ public/libs/tinymce/plugins/fullpage/plugin.min.js (+0 -9)
📝 public/libs/tinymce/plugins/fullscreen/plugin.min.js (+2 -7)
📝 public/libs/tinymce/plugins/help/plugin.min.js (+2 -7)
➖ public/libs/tinymce/plugins/hr/plugin.min.js (+0 -9)

...and 70 more files

📄 Description

Changes: https://www.tiny.cloud/docs/tinymce/6/6.0-release-notes-core-changes/#contents

For #3517

TODO

  • imagetools plugin functionality replacement.
    • Was only using imageoptions before, to show image options popup.
  • Think about table_use_colgroups & table_style_by_css (Set to false right now, to align with existing functionality).
  • Check pasting images (keyboard, mouse, drag & drop).
  • Check translations working.
  • Changed editor.dom.$ and editor.$ to editor.dom.select. Need to review every use as returned images are now different.
  • Dark mode looks to have new blue bar?
  • Details collapsible unwrap is broken, removes content.
  • Popup toolbars have extra line in them.

Old Image toolbar

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/3580 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 7/17/2022 **Status:** ✅ Merged **Merged:** 7/23/2022 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `tinymce6` --- ### 📝 Commits (7) - [`c519f70`](https://github.com/BookStackApp/BookStack/commit/c519f707e82693cfe6d392c04dd8e2efaeca24ca) Started upgrade to TinyMCE6, Untested - [`cd929b2`](https://github.com/BookStackApp/BookStack/commit/cd929b2555b0cc246d55df7380902a9eb2f9d2df) Made a bunch of tinymce 6 upgrade fixes - [`6a6f000`](https://github.com/BookStackApp/BookStack/commit/6a6f00058fd68a719be27552ae2a7d5b1667c16a) Added back in image options context toolbar item - [`a9ee2e6`](https://github.com/BookStackApp/BookStack/commit/a9ee2e6889e165d50583281189e91e6a6a611c24) Removed toolbar dialog background line - [`f86bb27`](https://github.com/BookStackApp/BookStack/commit/f86bb27a830b14cc7e872a3a735b9fe2b031032e) Ensured wysiwyg details contents are wrapped in block elements - [`8176ca1`](https://github.com/BookStackApp/BookStack/commit/8176ca153a9592c8e28f04b8e2c09bc8084c224b) Fixed blue wyswiyg toolbar in dark mode - [`aad2238`](https://github.com/BookStackApp/BookStack/commit/aad22384cb582bb7c403f47a14ae1ecf3f123469) Enabled modern tinymce table features ### 📊 Changes **90 files changed** (+1201 additions, -2138 deletions) <details> <summary>View changed files</summary> ➕ `public/libs/tinymce/custom-changes.md` (+17 -0) 📝 `public/libs/tinymce/icons/default/icons.min.js` (+1 -1) 📝 `public/libs/tinymce/license.txt` (+21 -504) ➕ `public/libs/tinymce/models/dom/model.min.js` (+4 -0) 📝 `public/libs/tinymce/plugins/advlist/plugin.min.js` (+2 -7) 📝 `public/libs/tinymce/plugins/anchor/plugin.min.js` (+2 -7) 📝 `public/libs/tinymce/plugins/autolink/plugin.min.js` (+2 -7) 📝 `public/libs/tinymce/plugins/autoresize/plugin.min.js` (+2 -7) 📝 `public/libs/tinymce/plugins/autosave/plugin.min.js` (+2 -7) ➖ `public/libs/tinymce/plugins/bbcode/plugin.min.js` (+0 -9) 📝 `public/libs/tinymce/plugins/charmap/plugin.min.js` (+2 -7) 📝 `public/libs/tinymce/plugins/code/plugin.min.js` (+2 -7) 📝 `public/libs/tinymce/plugins/codesample/plugin.min.js` (+2 -7) ➖ `public/libs/tinymce/plugins/colorpicker/plugin.min.js` (+0 -9) ➖ `public/libs/tinymce/plugins/contextmenu/plugin.min.js` (+0 -9) 📝 `public/libs/tinymce/plugins/directionality/plugin.min.js` (+2 -7) ➖ `public/libs/tinymce/plugins/fullpage/plugin.min.js` (+0 -9) 📝 `public/libs/tinymce/plugins/fullscreen/plugin.min.js` (+2 -7) 📝 `public/libs/tinymce/plugins/help/plugin.min.js` (+2 -7) ➖ `public/libs/tinymce/plugins/hr/plugin.min.js` (+0 -9) _...and 70 more files_ </details> ### 📄 Description Changes: https://www.tiny.cloud/docs/tinymce/6/6.0-release-notes-core-changes/#contents For #3517 ### TODO - [x] imagetools plugin functionality replacement. - Was only using `imageoptions` before, to show image options popup. - [x] Think about table_use_colgroups & table_style_by_css (Set to false right now, to align with existing functionality). - [x] Check pasting images (keyboard, mouse, drag & drop). - [x] Check translations working. - [x] Changed `editor.dom.$` and `editor.$` to `editor.dom.select`. Need to review every use as returned images are now different. - [x] Dark mode looks to have new blue bar? - [x] Details collapsible unwrap is broken, removes content. - [x] Popup toolbars have extra line in them. ### Old Image toolbar ![image](https://user-images.githubusercontent.com/8343178/179510662-b0cf2db6-8fed-47f1-aa10-0c1e6de6a1ae.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:27:18 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6230
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?