[PR #3593] [MERGED] Code-editor lang favorites system #6228

Closed
opened 2026-02-05 10:27:17 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/3593
Author: @ssddanbrown
Created: 7/24/2022
Status: Merged
Merged: 7/25/2022
Merged by: @ssddanbrown

Base: developmentHead: code-editor-favorites


📝 Commits (4)

  • ebc5a53 Started code-editor lang favorites system
  • 0df5ae0 Added core code-lang-favourites JS, PHP & CSS logic
  • 7fdc7c6 Added test to cover code favourite pref. endpoint
  • 8e5f7c6 Added language list favourites sorting, updated styles

📊 Changes

7 files changed (+161 additions, -47 deletions)

View changed files

📝 app/Http/Controllers/UserController.php (+21 -0)
📝 resources/js/code.mjs (+1 -1)
📝 resources/js/components/code-editor.js (+60 -7)
📝 resources/sass/_components.scss (+38 -2)
📝 resources/views/pages/parts/code-editor.blade.php (+20 -37)
📝 routes/web.php (+1 -0)
📝 tests/User/UserPreferencesTest.php (+20 -0)

📄 Description

Related to #3542

TODO

  • Need to sort favourites to the top, initial load and status change.
  • Back-end testing for endpoint.
  • Only show un-favourite-state button on hover? Changed to fade-out/in otherwise it would leave an awkward empty space.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/3593 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 7/24/2022 **Status:** ✅ Merged **Merged:** 7/25/2022 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `code-editor-favorites` --- ### 📝 Commits (4) - [`ebc5a53`](https://github.com/BookStackApp/BookStack/commit/ebc5a534104ce3708f5760799aaab42838078225) Started code-editor lang favorites system - [`0df5ae0`](https://github.com/BookStackApp/BookStack/commit/0df5ae0658b5ff409c2cc3d3da278692f80c790d) Added core code-lang-favourites JS, PHP & CSS logic - [`7fdc7c6`](https://github.com/BookStackApp/BookStack/commit/7fdc7c68b9d004ef3ffd9f750f8c8795abe9e238) Added test to cover code favourite pref. endpoint - [`8e5f7c6`](https://github.com/BookStackApp/BookStack/commit/8e5f7c642527fd25f4c62d2dad6c878128226c87) Added language list favourites sorting, updated styles ### 📊 Changes **7 files changed** (+161 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/UserController.php` (+21 -0) 📝 `resources/js/code.mjs` (+1 -1) 📝 `resources/js/components/code-editor.js` (+60 -7) 📝 `resources/sass/_components.scss` (+38 -2) 📝 `resources/views/pages/parts/code-editor.blade.php` (+20 -37) 📝 `routes/web.php` (+1 -0) 📝 `tests/User/UserPreferencesTest.php` (+20 -0) </details> ### 📄 Description Related to #3542 ### TODO - [x] Need to sort favourites to the top, initial load and status change. - [x] Back-end testing for endpoint. - [x] ~~Only show un-favourite-state button on hover~~? Changed to fade-out/in otherwise it would leave an awkward empty space. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:27:17 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6228