[PR #3504] [CLOSED] Migrate self referential links on copy #6208

New Issue

OVERLORD · 2026-02-05T10:26:53+03:00

OVERLORD commented

2026-02-05 10:26:53 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/3504
Author: @bourdaisj
Created: 6/16/2022
Status: ❌ Closed

Base: development ← Head: update_self_ref_links_when_cloning

📝 Commits (4)

b1af419 wip: migrate self referential links on copy
cc46bc6 work in progress
2e30523 regex for book cloning
b8961da poc chapter cloning

📊 Changes

6 files changed (+251 additions, -5 deletions)

View changed files

📝 app/Entities/Tools/Cloner.php (+60 -4)
📝 app/Http/Controllers/PageController.php (+3 -1)
📝 database/factories/Entities/Models/PageFactory.php (+1 -0)
📝 tests/Entity/BookTest.php (+64 -0)
📝 tests/Entity/ChapterTest.php (+103 -0)
📝 tests/Entity/PageTest.php (+20 -0)

📄 Description

Early draft PR for https://github.com/BookStackApp/BookStack/issues/3239

Figure out which tests we need to add to cover every use-case/path
Write the actual tests
Do the actual implementation
Test it on entities with very large content to make sure we're not harming performances too much

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/3504 **Author:** [@bourdaisj](https://github.com/bourdaisj) **Created:** 6/16/2022 **Status:** ❌ Closed **Base:** `development` ← **Head:** `update_self_ref_links_when_cloning` --- ### 📝 Commits (4) - [`b1af419`](https://github.com/BookStackApp/BookStack/commit/b1af419704052da1480d3243b37569bfd034b363) wip: migrate self referential links on copy - [`cc46bc6`](https://github.com/BookStackApp/BookStack/commit/cc46bc690db5a99e335cbd21cac289cfdff28e0a) work in progress - [`2e30523`](https://github.com/BookStackApp/BookStack/commit/2e305231cbb3eed0db9717a8a796aec49521fc15) regex for book cloning - [`b8961da`](https://github.com/BookStackApp/BookStack/commit/b8961dab74050e262301a6129ee46ac1c34872ea) poc chapter cloning ### 📊 Changes **6 files changed** (+251 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/Entities/Tools/Cloner.php` (+60 -4) 📝 `app/Http/Controllers/PageController.php` (+3 -1) 📝 `database/factories/Entities/Models/PageFactory.php` (+1 -0) 📝 `tests/Entity/BookTest.php` (+64 -0) 📝 `tests/Entity/ChapterTest.php` (+103 -0) 📝 `tests/Entity/PageTest.php` (+20 -0) </details> ### 📄 Description Early draft PR for https://github.com/BookStackApp/BookStack/issues/3239 - [x] Figure out which tests we need to add to cover every use-case/path - [ ] Write the actual tests - [ ] Do the actual implementation - [ ] Test it on entities with very large content to make sure we're not harming performances too much --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:26:53 +03:00

OVERLORD closed this issue

2026-02-05 10:26:57 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6208