[PR #3483] [CLOSED] Feature/favourites api #6202

Closed
opened 2026-02-05 10:26:46 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/3483
Author: @bytepoets-ssi
Created: 6/8/2022
Status: Closed

Base: developmentHead: feature/favourites_api


📝 Commits (3)

  • 11ce921 Show is_favourite status in list and read API call
  • 8e9c9fa Add API route to update favourite status
  • 0a457df Fix code format issue

📊 Changes

6 files changed (+68 additions, -7 deletions)

View changed files

📝 app/Entities/Models/Page.php (+3 -2)
📝 app/Http/Controllers/Api/PageApiController.php (+39 -2)
📝 dev/api/responses/pages-list.json (+6 -3)
📝 dev/api/responses/pages-read.json (+1 -0)
📝 routes/api.php (+1 -0)
📝 tests/Api/PagesApiTest.php (+18 -0)

📄 Description

Resolves #3471

That would be a simple implementation of favourites in the API. I haven't tested the performance impact for the list API call. There is as well a slightly different situation as at the other API calls which we can discuss, because every user can change its favourite status regardless of the permission.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/3483 **Author:** [@bytepoets-ssi](https://github.com/bytepoets-ssi) **Created:** 6/8/2022 **Status:** ❌ Closed **Base:** `development` ← **Head:** `feature/favourites_api` --- ### 📝 Commits (3) - [`11ce921`](https://github.com/BookStackApp/BookStack/commit/11ce92137b364b8372968b409e227ab85f749a93) Show is_favourite status in list and read API call - [`8e9c9fa`](https://github.com/BookStackApp/BookStack/commit/8e9c9fa97b05f8e3231be58629b7ec1a39605116) Add API route to update favourite status - [`0a457df`](https://github.com/BookStackApp/BookStack/commit/0a457dfef3bd4a67333c9c64a360b32a3a2e56df) Fix code format issue ### 📊 Changes **6 files changed** (+68 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `app/Entities/Models/Page.php` (+3 -2) 📝 `app/Http/Controllers/Api/PageApiController.php` (+39 -2) 📝 `dev/api/responses/pages-list.json` (+6 -3) 📝 `dev/api/responses/pages-read.json` (+1 -0) 📝 `routes/api.php` (+1 -0) 📝 `tests/Api/PagesApiTest.php` (+18 -0) </details> ### 📄 Description Resolves #3471 That would be a simple implementation of favourites in the API. I haven't tested the performance impact for the list API call. There is as well a slightly different situation as at the other API calls which we can discuss, because every user can change its favourite status regardless of the permission. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:26:46 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6202