[PR #3433] [MERGED] Bunch of tiny improvements #6197

New Issue

OVERLORD · 2026-02-05T10:26:40+03:00

OVERLORD commented

2026-02-05 10:26:40 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/3433
Author: @ssddanbrown
Created: 5/13/2022
Status: ✅ Merged
Merged: 5/30/2022
Merged by: @ssddanbrown

Base: development ← Head: tiny_improvements

📝 Commits (10+)

bef2045 Embedded css sources for easier firefox dev work
221d910 Reduced excess margin in chapter contents lists
a0fe614 Improved the display of dropdown menus
24b31b6 Cleaned up entity details listing
60e319c Tidied up book navigation styles
e6864a9 Improved card list design
2c74dfd Updated breadcrumb dropdown styles, improved keyboard nav
89dfa43 Fixed loading animation delay
35a47a2 Added animation transition for breadcrumb dropdown load
78920d7 Updated tri-layout sidebars to not be cut-off by padding

📊 Changes

37 files changed (+651 additions, -332 deletions)

View changed files

📝 package.json (+2 -2)
➕ resources/icons/download.svg (+1 -0)
📝 resources/js/code.mjs (+15 -0)
➕ resources/js/components/chapter-contents.js (+37 -0)
➖ resources/js/components/chapter-toggle.js (+0 -33)
➕ resources/js/components/code-textarea.js (+16 -0)
📝 resources/js/components/dropdown-search.js (+3 -0)
📝 resources/js/components/dropdown.js (+24 -8)
📝 resources/js/components/index.js (+4 -2)
📝 resources/js/services/animations.js (+34 -2)
📝 resources/lang/en/common.php (+2 -0)
📝 resources/sass/_blocks.scss (+0 -1)
📝 resources/sass/_components.scss (+58 -10)
📝 resources/sass/_forms.scss (+11 -8)
📝 resources/sass/_header.scss (+54 -49)
📝 resources/sass/_layout.scss (+9 -2)
📝 resources/sass/_lists.scss (+119 -45)
📝 resources/sass/_pages.scss (+5 -1)
📝 resources/sass/styles.scss (+4 -4)
📝 resources/views/attachments/list.blade.php (+21 -4)

...and 17 more files

📄 Description

Just opening this PR to track a set of smaller changes.

Changes

Reduced excess margins in chapter contents list.
Updated tri-layout sidebars to not be cut-off by padding.
Improved input size consistency. Related to #2678.
Fixed skip-to-content link shadow being slightly visible.
Improved the display of dropdown menus:
- Tweaked styling to add a little extra shadow and be more rounded to
  match other UI areas.
- Added slight horizontal inset when in right sidebar to prevent shadow
  being cut-off in most cases.
- Added logic to "drop upwards" if dropping down would take the menu
  offscreen.
Cleaned up content details section:
- Prevented wrapping around icon.
- Updated font-size to match other UI content.
- Updated spacing and line-heights to be a tad better laid-out.
Tidied up book navigation sidebar styles:
- Removed background track line since it would darken entity item bars.
- Updated item spacing to be a bit tighter.
- Updated action hover styles to be a bit lighter, and visible on dark
  mode, to fit rest of system.
Improved card list design:
- Removed border and rounded list item styles to make hover states have
  less edge detail and to align with other UI elements.
- In expanded-detail view, removed space used for entity description if
  there is not description content existing.
Updated breadcrumb dropdown styles, improved keyboard nav:
- Removed harsh theme color border between search and content.
- Prevented intermediate focus on list container to align arrow & tab
  behavior, and to get to content quicker.
Refined header bar styles:
- Updated many items to be flexbox-based.
- Updated & aligned hover states across header bar items.
Aligned collapsed header dropdown item styles.
Made the "Custom HTML Head Content" setting a highlighted code editor.
Tweaked chapter list item styles:
- Improves animation smoothness.
- Cleaned spacing to match page items in books listing.
Made chapter toggle in book sidebar nav more consistent.
Updated attachment links to have dropdown for open type for easier inline usage access.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/3433 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 5/13/2022 **Status:** ✅ Merged **Merged:** 5/30/2022 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `tiny_improvements` --- ### 📝 Commits (10+) - [`bef2045`](https://github.com/BookStackApp/BookStack/commit/bef2045df1c62ca9b2622e924cd8757050acd96f) Embedded css sources for easier firefox dev work - [`221d910`](https://github.com/BookStackApp/BookStack/commit/221d910ff299fec49f343d3d27f66fa03f3f60aa) Reduced excess margin in chapter contents lists - [`a0fe614`](https://github.com/BookStackApp/BookStack/commit/a0fe6147d8a658c21271c54110aec2251f4ed08a) Improved the display of dropdown menus - [`24b31b6`](https://github.com/BookStackApp/BookStack/commit/24b31b624c0f80bc9a9cd3f29fab97fa18f711d1) Cleaned up entity details listing - [`60e319c`](https://github.com/BookStackApp/BookStack/commit/60e319c4b444d84a51f8d914120b6fe4106d7fbe) Tidied up book navigation styles - [`e6864a9`](https://github.com/BookStackApp/BookStack/commit/e6864a9cff4bb5e6b16caf53720ac12229815422) Improved card list design - [`2c74dfd`](https://github.com/BookStackApp/BookStack/commit/2c74dfd1d4e7f030425221cfc8f7e1f6819c8992) Updated breadcrumb dropdown styles, improved keyboard nav - [`89dfa43`](https://github.com/BookStackApp/BookStack/commit/89dfa43e73be80c571d1929e721d5ba1340a06ba) Fixed loading animation delay - [`35a47a2`](https://github.com/BookStackApp/BookStack/commit/35a47a273b9364cdcb459eb835fcda355c91df52) Added animation transition for breadcrumb dropdown load - [`78920d7`](https://github.com/BookStackApp/BookStack/commit/78920d7d6555fbb1a06b83a9f72ecab64d1cae9d) Updated tri-layout sidebars to not be cut-off by padding ### 📊 Changes **37 files changed** (+651 additions, -332 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+2 -2) ➕ `resources/icons/download.svg` (+1 -0) 📝 `resources/js/code.mjs` (+15 -0) ➕ `resources/js/components/chapter-contents.js` (+37 -0) ➖ `resources/js/components/chapter-toggle.js` (+0 -33) ➕ `resources/js/components/code-textarea.js` (+16 -0) 📝 `resources/js/components/dropdown-search.js` (+3 -0) 📝 `resources/js/components/dropdown.js` (+24 -8) 📝 `resources/js/components/index.js` (+4 -2) 📝 `resources/js/services/animations.js` (+34 -2) 📝 `resources/lang/en/common.php` (+2 -0) 📝 `resources/sass/_blocks.scss` (+0 -1) 📝 `resources/sass/_components.scss` (+58 -10) 📝 `resources/sass/_forms.scss` (+11 -8) 📝 `resources/sass/_header.scss` (+54 -49) 📝 `resources/sass/_layout.scss` (+9 -2) 📝 `resources/sass/_lists.scss` (+119 -45) 📝 `resources/sass/_pages.scss` (+5 -1) 📝 `resources/sass/styles.scss` (+4 -4) 📝 `resources/views/attachments/list.blade.php` (+21 -4) _...and 17 more files_ </details> ### 📄 Description Just opening this PR to track a set of smaller changes. #### Changes - Reduced excess margins in chapter contents list. - Updated tri-layout sidebars to not be cut-off by padding. - Improved input size consistency. Related to #2678. - Fixed skip-to-content link shadow being slightly visible. - Improved the display of dropdown menus: - Tweaked styling to add a little extra shadow and be more rounded to match other UI areas. - Added slight horizontal inset when in right sidebar to prevent shadow being cut-off in most cases. - Added logic to "drop upwards" if dropping down would take the menu offscreen. - Cleaned up content details section: - Prevented wrapping around icon. - Updated font-size to match other UI content. - Updated spacing and line-heights to be a tad better laid-out. - Tidied up book navigation sidebar styles: - Removed background track line since it would darken entity item bars. - Updated item spacing to be a bit tighter. - Updated action hover styles to be a bit lighter, and visible on dark mode, to fit rest of system. - Improved card list design: - Removed border and rounded list item styles to make hover states have less edge detail and to align with other UI elements. - In expanded-detail view, removed space used for entity description if there is not description content existing. - Updated breadcrumb dropdown styles, improved keyboard nav: - Removed harsh theme color border between search and content. - Prevented intermediate focus on list container to align arrow & tab behavior, and to get to content quicker. - Refined header bar styles: - Updated many items to be flexbox-based. - Updated & aligned hover states across header bar items. - Aligned collapsed header dropdown item styles. - Made the "Custom HTML Head Content" setting a highlighted code editor. - Tweaked chapter list item styles: - Improves animation smoothness. - Cleaned spacing to match page items in books listing. - Made chapter toggle in book sidebar nav more consistent. - Updated attachment links to have dropdown for open type for easier inline usage access. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:26:40 +03:00

OVERLORD closed this issue

2026-02-05 10:26:41 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6197