[PR #3416] [MERGED] Added ability to escape role "External Auth ID" commas #6196

New Issue

OVERLORD · 2026-02-05T10:26:36+03:00

OVERLORD commented

2026-02-05 10:26:36 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/3416
Author: @ssddanbrown
Created: 5/4/2022
Status: ✅ Merged
Merged: 5/30/2022
Merged by: @ssddanbrown

Base: development ← Head: group_sync_comma_escaping

📝 Commits (1)

d795af0 Added ability to escape role "External Auth ID" commas

📊 Changes

3 files changed (+74 additions, -4 deletions)

View changed files

📝 app/Auth/Access/GroupSyncService.php (+14 -4)
📝 database/factories/Auth/RoleFactory.php (+1 -0)
➕ tests/Auth/GroupSyncServiceTest.php (+59 -0)

📄 Description

Using a backslash in this field before a comma.
Could potentially (Although unlikely) be a breaking change.

For #3405

Docs Updates

Update docs to note commas in "External Authentication Ids" field will be used literally (Instead of defining multiple mappings).
Add update notice for potential breaking change if \, is used within "External Authentication Ids" already.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/3416 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 5/4/2022 **Status:** ✅ Merged **Merged:** 5/30/2022 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `group_sync_comma_escaping` --- ### 📝 Commits (1) - [`d795af0`](https://github.com/BookStackApp/BookStack/commit/d795af04dfa69fe1fc95f13aa0b0d43f3bdac268) Added ability to escape role "External Auth ID" commas ### 📊 Changes **3 files changed** (+74 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `app/Auth/Access/GroupSyncService.php` (+14 -4) 📝 `database/factories/Auth/RoleFactory.php` (+1 -0) ➕ `tests/Auth/GroupSyncServiceTest.php` (+59 -0) </details> ### 📄 Description - Using a backslash in this field before a comma. - Could potentially (Although unlikely) be a breaking change. For #3405 ### Docs Updates - Update docs to note commas in "External Authentication Ids" field will be used literally (Instead of defining multiple mappings). - Add update notice for potential breaking change if `\,` is used within "External Authentication Ids" already. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:26:36 +03:00

OVERLORD closed this issue

2026-02-05 10:26:37 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6196