[PR #3333] [MERGED] WYSIWYG tasklist support #6181

Closed
opened 2026-02-05 10:26:18 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/3333
Author: @ssddanbrown
Created: 3/19/2022
Status: Merged
Merged: 3/23/2022
Merged by: @ssddanbrown

Base: developmentHead: wysiwyg_tasklist


📝 Commits (8)

  • f991948 Started initial tasklist attempt, failed implementation
  • 65dd7ad Changed to a psuedo-style approach for tasklist in wysiwyg
  • b6be8a2 Added WYSIWYG tasklist clicking ability
  • 5ae9ed1 Added functioning wysiwyg tasklist toolbar button
  • ea62fe6 Improved tasklist wysiwyg behaviour
  • c5aad29 Added tasklist support to markdown exporter
  • 883e18f Updated tasklist style and functionality for cross-browser use
  • 95e496d Added translation string for tasklist WYSIWYG action

📊 Changes

10 files changed (+256 additions, -2 deletions)

View changed files

app/Entities/Tools/Markdown/CheckboxConverter.php (+28 -0)
📝 app/Entities/Tools/Markdown/HtmlToMarkdown.php (+1 -0)
📝 resources/js/wysiwyg/config.js (+4 -1)
resources/js/wysiwyg/plugins-tasklist.js (+171 -0)
📝 resources/js/wysiwyg/toolbars.js (+1 -1)
📝 resources/lang/en/editor.php (+1 -0)
📝 resources/sass/_pages.scss (+5 -0)
📝 resources/sass/_text.scss (+1 -0)
📝 resources/sass/_tinymce.scss (+32 -0)
📝 tests/Entity/ExportTest.php (+12 -0)

📄 Description

Remaining Todo

  • Add ability for click toggle within editor.
  • Create tasklist button for editor.
    • Check interopability with other list buttons/formats.
  • Check compatibility with markdown export format.
  • Check compatibility with markdown editor format.
  • Check display on exports.
  • Test styling is reasonable across browsers, also functionality.
  • Update editor language translations with added strings.
  • Move tasklist action to overflow.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/3333 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 3/19/2022 **Status:** ✅ Merged **Merged:** 3/23/2022 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `development` ← **Head:** `wysiwyg_tasklist` --- ### 📝 Commits (8) - [`f991948`](https://github.com/BookStackApp/BookStack/commit/f991948c4931ecf2d4e32dadc8b099207f76fa82) Started initial tasklist attempt, failed implementation - [`65dd7ad`](https://github.com/BookStackApp/BookStack/commit/65dd7ad1e91f01f3ee1250fcb18fafb4c0429463) Changed to a psuedo-style approach for tasklist in wysiwyg - [`b6be8a2`](https://github.com/BookStackApp/BookStack/commit/b6be8a2bb9a640eef14e67376cbb57f999084ca9) Added WYSIWYG tasklist clicking ability - [`5ae9ed1`](https://github.com/BookStackApp/BookStack/commit/5ae9ed1e226638096a85d79836962397b6bbb263) Added functioning wysiwyg tasklist toolbar button - [`ea62fe6`](https://github.com/BookStackApp/BookStack/commit/ea62fe6004b2403c245d02a0b957f29d9c232ccd) Improved tasklist wysiwyg behaviour - [`c5aad29`](https://github.com/BookStackApp/BookStack/commit/c5aad29c72e204605e7f0c5fa03d631bcb147cdf) Added tasklist support to markdown exporter - [`883e18f`](https://github.com/BookStackApp/BookStack/commit/883e18f7c4fe474d688b08bbc7d95643f1680a57) Updated tasklist style and functionality for cross-browser use - [`95e496d`](https://github.com/BookStackApp/BookStack/commit/95e496d16fbbb6164603f53edc1f0104febe7a79) Added translation string for tasklist WYSIWYG action ### 📊 Changes **10 files changed** (+256 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `app/Entities/Tools/Markdown/CheckboxConverter.php` (+28 -0) 📝 `app/Entities/Tools/Markdown/HtmlToMarkdown.php` (+1 -0) 📝 `resources/js/wysiwyg/config.js` (+4 -1) ➕ `resources/js/wysiwyg/plugins-tasklist.js` (+171 -0) 📝 `resources/js/wysiwyg/toolbars.js` (+1 -1) 📝 `resources/lang/en/editor.php` (+1 -0) 📝 `resources/sass/_pages.scss` (+5 -0) 📝 `resources/sass/_text.scss` (+1 -0) 📝 `resources/sass/_tinymce.scss` (+32 -0) 📝 `tests/Entity/ExportTest.php` (+12 -0) </details> ### 📄 Description ### Remaining Todo - [x] Add ability for click toggle within editor. - [x] Create tasklist button for editor. - [x] Check interopability with other list buttons/formats. - [x] Check compatibility with markdown export format. - [x] Check compatibility with markdown editor format. - [x] Check display on exports. - [x] Test styling is reasonable across browsers, also functionality. - [x] Update editor language translations with added strings. - [x] Move tasklist action to overflow. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:26:18 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6181