[PR #3179] [MERGED] When creating a user, do not persist the user on invitation sending failure #6148

New Issue

OVERLORD · 2026-02-05T10:25:32+03:00

OVERLORD commented

2026-02-05 10:25:32 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/3179
Author: @bourdaisj
Created: 1/19/2022
Status: ✅ Merged
Merged: 1/24/2022
Merged by: @ssddanbrown

Base: master ← Head: atomic-user-creation

📝 Commits (1)

c9beacb fix(User Creation): do not persist the user if invitation fails

📊 Changes

2 files changed (+60 additions, -11 deletions)

View changed files

📝 app/Http/Controllers/UserController.php (+15 -11)
📝 tests/User/UserManagementTest.php (+45 -0)

📄 Description

See https://github.com/BookStackApp/BookStack/issues/3174

What this PR do:

Wrap the user creation process in a transaction
Add test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/3179 **Author:** [@bourdaisj](https://github.com/bourdaisj) **Created:** 1/19/2022 **Status:** ✅ Merged **Merged:** 1/24/2022 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `atomic-user-creation` --- ### 📝 Commits (1) - [`c9beacb`](https://github.com/BookStackApp/BookStack/commit/c9beacbfbf54b965a924a1efdb312390a207639c) fix(User Creation): do not persist the user if invitation fails ### 📊 Changes **2 files changed** (+60 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/UserController.php` (+15 -11) 📝 `tests/User/UserManagementTest.php` (+45 -0) </details> ### 📄 Description See https://github.com/BookStackApp/BookStack/issues/3174 What this PR do: - Wrap the user creation process in a transaction - Add test --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:25:32 +03:00

OVERLORD closed this issue

2026-02-05 10:25:34 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6148