[PR #3072] [MERGED] Support custom commands via logical theme system #6128

Closed
opened 2026-02-05 10:25:08 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/3072
Author: @ssddanbrown
Created: 11/22/2021
Status: Merged
Merged: 11/22/2021
Merged by: @ssddanbrown

Base: masterHead: logical_theme_commands


📝 Commits (2)

  • cdaad2f Support custom commands via logical theme system
  • cb30c25 Added test for logical-theme-system command registration

📊 Changes

3 files changed (+57 additions, -0 deletions)

View changed files

📝 app/Theming/ThemeService.php (+12 -0)
📝 dev/docs/logical-theme-system.md (+26 -0)
📝 tests/ThemeTest.php (+19 -0)

📄 Description

Added initial work to support registering commands through the logical
theme system. Includes docs changes and example.

Related to #2288


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/3072 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 11/22/2021 **Status:** ✅ Merged **Merged:** 11/22/2021 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `logical_theme_commands` --- ### 📝 Commits (2) - [`cdaad2f`](https://github.com/BookStackApp/BookStack/commit/cdaad2f40ec96fd98e6320638854c69b90bfe847) Support custom commands via logical theme system - [`cb30c25`](https://github.com/BookStackApp/BookStack/commit/cb30c258df2215ba73364cc6df9f3741f603d6a5) Added test for logical-theme-system command registration ### 📊 Changes **3 files changed** (+57 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/Theming/ThemeService.php` (+12 -0) 📝 `dev/docs/logical-theme-system.md` (+26 -0) 📝 `tests/ThemeTest.php` (+19 -0) </details> ### 📄 Description Added initial work to support registering commands through the logical theme system. Includes docs changes and example. Related to #2288 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:25:08 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6128