[PR #3039] [MERGED] Static Analysis #6119

New Issue

OVERLORD · 2026-02-05T10:24:56+03:00

OVERLORD commented

2026-02-05 10:24:56 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/3039
Author: @ssddanbrown
Created: 11/5/2021
Status: ✅ Merged
Merged: 11/5/2021
Merged by: @ssddanbrown

Base: master ← Head: phpstan

📝 Commits (2)

bc291be Added inital phpstan/larastan setup
5c6a6b5 Applied StyleCI changes, added php/larastan to attribution

📊 Changes

22 files changed (+1121 additions, -153 deletions)

View changed files

➕ .github/workflows/phpstan.yml (+41 -0)
📝 .github/workflows/phpunit.yml (+1 -1)
📝 .gitignore (+2 -1)
📝 app/Api/ApiDocsGenerator.php (+1 -1)
📝 app/Auth/User.php (+0 -1)
📝 app/Config/broadcasting.php (+29 -57)
📝 app/Config/cache.php (+29 -41)
📝 app/Config/database.php (+1 -1)
📝 app/Console/Commands/CreateAdmin.php (+15 -4)
📝 app/Entities/Repos/BookshelfRepo.php (+2 -1)
📝 app/Entities/Tools/SearchOptions.php (+2 -2)
📝 app/Entities/Tools/TrashCan.php (+2 -0)
📝 app/Http/Controllers/StatusController.php (+2 -2)
📝 app/Uploads/AttachmentService.php (+4 -4)
📝 app/Uploads/ImageRepo.php (+1 -1)
📝 app/Uploads/ImageService.php (+4 -5)
➕ bootstrap/phpstan.php (+6 -0)
📝 composer.json (+3 -2)
📝 composer.lock (+950 -27)
➕ phpstan.neon.dist (+23 -0)

...and 2 more files

📄 Description

using phpstan/larastan

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/3039 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 11/5/2021 **Status:** ✅ Merged **Merged:** 11/5/2021 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `phpstan` --- ### 📝 Commits (2) - [`bc291be`](https://github.com/BookStackApp/BookStack/commit/bc291bee783a3124aa9c123de59b3acd4719b106) Added inital phpstan/larastan setup - [`5c6a6b5`](https://github.com/BookStackApp/BookStack/commit/5c6a6b50a0c4d42fa245fa7aa8c2e7315d56e3ff) Applied StyleCI changes, added php/larastan to attribution ### 📊 Changes **22 files changed** (+1121 additions, -153 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/phpstan.yml` (+41 -0) 📝 `.github/workflows/phpunit.yml` (+1 -1) 📝 `.gitignore` (+2 -1) 📝 `app/Api/ApiDocsGenerator.php` (+1 -1) 📝 `app/Auth/User.php` (+0 -1) 📝 `app/Config/broadcasting.php` (+29 -57) 📝 `app/Config/cache.php` (+29 -41) 📝 `app/Config/database.php` (+1 -1) 📝 `app/Console/Commands/CreateAdmin.php` (+15 -4) 📝 `app/Entities/Repos/BookshelfRepo.php` (+2 -1) 📝 `app/Entities/Tools/SearchOptions.php` (+2 -2) 📝 `app/Entities/Tools/TrashCan.php` (+2 -0) 📝 `app/Http/Controllers/StatusController.php` (+2 -2) 📝 `app/Uploads/AttachmentService.php` (+4 -4) 📝 `app/Uploads/ImageRepo.php` (+1 -1) 📝 `app/Uploads/ImageService.php` (+4 -5) ➕ `bootstrap/phpstan.php` (+6 -0) 📝 `composer.json` (+3 -2) 📝 `composer.lock` (+950 -27) ➕ `phpstan.neon.dist` (+23 -0) _...and 2 more files_ </details> ### 📄 Description using phpstan/larastan --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:24:56 +03:00

OVERLORD closed this issue

2026-02-05 10:24:58 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6119