[PR #3000] [MERGED] Fixes padding issues of the sidebar's items #6102

Closed
opened 2026-02-05 10:24:35 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/3000
Author: @ffranchina
Created: 10/22/2021
Status: Merged
Merged: 10/24/2021
Merged by: @ssddanbrown

Base: masterHead: fix_sidebar_css


📝 Commits (1)

  • 0b15e2b Fixes padding issues of the sidebar's items

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 resources/sass/_lists.scss (+3 -2)

📄 Description

Hello!

Using this amazing platform I realized there was a very minor graphical bug that was still bothering me.
What I found is that the text item is padded on one side but not on the other. While I can totally understand the reason of way it works like this and the code is cleaner to understand, I believe it's a bit odd to see the text this much close to the border of the item's area.
Schermata da 2021-10-10 21-08-55
Schermata da 2021-10-10 21-09-07
Schermata da 2021-10-10 21-09-16

So I tweaked the scss code in such a way of putting that padding where I think it should be for the sake of consistency with the rest of the interface. Basically I removed the padding from the a item and I put it to the text h4 item.
Schermata da 2021-10-21 01-31-51
Schermata da 2021-10-21 01-31-56
Schermata da 2021-10-21 01-32-01
Schermata da 2021-10-21 01-32-07

I applied this change to the platform that I am running and I wanted to share it with you in case you believe that the current behavior is not how it should be. If, instead, you think this is not an issue or you want to apply a different solution, feel free to ignore this PR.

As always, thanks for your time and work! :D


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/3000 **Author:** [@ffranchina](https://github.com/ffranchina) **Created:** 10/22/2021 **Status:** ✅ Merged **Merged:** 10/24/2021 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `fix_sidebar_css` --- ### 📝 Commits (1) - [`0b15e2b`](https://github.com/BookStackApp/BookStack/commit/0b15e2bf1c8f1e196c9c64f3684b3c81f6699ef2) Fixes padding issues of the sidebar's items ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `resources/sass/_lists.scss` (+3 -2) </details> ### 📄 Description Hello! Using this amazing platform I realized there was a very minor graphical bug that was still bothering me. What I found is that the text item is padded on one side but not on the other. While I can totally understand the reason of way it works like this and the code is cleaner to understand, I believe it's a bit odd to see the text this much close to the border of the item's area. ![Schermata da 2021-10-10 21-08-55](https://user-images.githubusercontent.com/8852116/138372500-0117c9c5-7f41-470e-9465-55651e9329cb.png) ![Schermata da 2021-10-10 21-09-07](https://user-images.githubusercontent.com/8852116/138372505-4bba4b21-290e-4bbb-b466-fb975e71b886.png) ![Schermata da 2021-10-10 21-09-16](https://user-images.githubusercontent.com/8852116/138372507-df55e884-684c-42ad-91d9-19ca539fe5a0.png) So I tweaked the `scss` code in such a way of putting that padding where I think it should be for the sake of consistency with the rest of the interface. Basically I removed the padding from the `a` item and I put it to the text `h4` item. ![Schermata da 2021-10-21 01-31-51](https://user-images.githubusercontent.com/8852116/138372854-55b436cf-53e9-4994-ae9e-cf0109f42d7f.png) ![Schermata da 2021-10-21 01-31-56](https://user-images.githubusercontent.com/8852116/138372856-35f107ea-7b6d-46f0-b54e-ae916e30b716.png) ![Schermata da 2021-10-21 01-32-01](https://user-images.githubusercontent.com/8852116/138372879-cdb2d77e-163a-4024-8071-31167b40cde1.png) ![Schermata da 2021-10-21 01-32-07](https://user-images.githubusercontent.com/8852116/138372881-86c37dcf-f80b-4b2a-b6d2-e78937ae5650.png) I applied this change to the platform that I am running and I wanted to share it with you in case you believe that the current behavior is not how it should be. If, instead, you think this is not an issue or you want to apply a different solution, feel free to ignore this PR. As always, thanks for your time and work! :D --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:24:35 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6102