[PR #2928] [MERGED] Convert old BrowserKit tests #6092

New Issue

OVERLORD · 2026-02-05T10:24:20+03:00

OVERLORD commented

2026-02-05 10:24:20 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/2928
Author: @ssddanbrown
Created: 9/14/2021
Status: ✅ Merged
Merged: 9/18/2021
Merged by: @ssddanbrown

Base: master ← Head: browserkit_removal

📝 Commits (9)

badaf08 Removed browserkit from a couple of classess
121a746 Moved/Updated old Activity tracking tests, started on entity tests
de8cceb Moved more tests out of EntityTest
5d93dd2 Finished moving EntityTests out to new TestCase files
90c759e Rewrote entity permissions tests to be non-browser-kit
a4d9bca Converted AuthTest away from BrowserKit
d74255d Started updating RolesTest away from Browserkit
6454e24 Removed browserkit testing from project
c08c8d7 Applied styleci style changes

📊 Changes

25 files changed (+1717 additions, -1910 deletions)

View changed files

📝 app/Actions/Comment.php (+5 -4)
📝 app/Auth/Role.php (+7 -6)
📝 app/Entities/Models/Book.php (+6 -3)
📝 app/Exceptions/StoppedAuthenticationException.php (+1 -1)
📝 composer.json (+3 -3)
📝 composer.lock (+165 -173)
➖ tests/ActivityTrackingTest.php (+0 -37)
📝 tests/Auth/AuthTest.php (+144 -264)
➖ tests/BrowserKitTest.php (+0 -218)
📝 tests/Entity/BookShelfTest.php (+8 -0)
📝 tests/Entity/BookTest.php (+157 -1)
📝 tests/Entity/ChapterTest.php (+25 -1)
➕ tests/Entity/EntityAccessTest.php (+52 -0)
➖ tests/Entity/EntityTest.php (+0 -319)
➖ tests/Entity/MarkdownTest.php (+0 -53)
📝 tests/Entity/PageDraftTest.php (+47 -41)
➕ tests/Entity/PageEditorTest.php (+77 -0)
📝 tests/Entity/PageTest.php (+84 -16)
📝 tests/Entity/SortTest.php (+28 -0)
📝 tests/Permissions/EntityPermissionsTest.php (+318 -326)

...and 5 more files

📄 Description

Been slowly doing but just need to get this finally done so we don't have this lying around as we head towards Laravel 8/9.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/2928 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 9/14/2021 **Status:** ✅ Merged **Merged:** 9/18/2021 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `browserkit_removal` --- ### 📝 Commits (9) - [`badaf08`](https://github.com/BookStackApp/BookStack/commit/badaf08e554e172051db0b8e210b734d8355ba58) Removed browserkit from a couple of classess - [`121a746`](https://github.com/BookStackApp/BookStack/commit/121a746d591e2f79d7426a63645b37c73ad8f2ba) Moved/Updated old Activity tracking tests, started on entity tests - [`de8cceb`](https://github.com/BookStackApp/BookStack/commit/de8cceb0f72f19ed0b3aa43d7a139639fa634bd2) Moved more tests out of EntityTest - [`5d93dd2`](https://github.com/BookStackApp/BookStack/commit/5d93dd258ebc7fe5f63567597fea75c3059ddbf0) Finished moving EntityTests out to new TestCase files - [`90c759e`](https://github.com/BookStackApp/BookStack/commit/90c759e5caf489bd0524c988cb89b593c7259ff7) Rewrote entity permissions tests to be non-browser-kit - [`a4d9bca`](https://github.com/BookStackApp/BookStack/commit/a4d9bca9e1dd90615bf9ad5c3ad1811614440423) Converted AuthTest away from BrowserKit - [`d74255d`](https://github.com/BookStackApp/BookStack/commit/d74255df5db46c8d57907e793a99bf3d167113c7) Started updating RolesTest away from Browserkit - [`6454e24`](https://github.com/BookStackApp/BookStack/commit/6454e246574a6bdb75a5a908a29a06214af7cc60) Removed browserkit testing from project - [`c08c8d7`](https://github.com/BookStackApp/BookStack/commit/c08c8d7aa32a66742fe44e6f6b271accf6a35591) Applied styleci style changes ### 📊 Changes **25 files changed** (+1717 additions, -1910 deletions) <details> <summary>View changed files</summary> 📝 `app/Actions/Comment.php` (+5 -4) 📝 `app/Auth/Role.php` (+7 -6) 📝 `app/Entities/Models/Book.php` (+6 -3) 📝 `app/Exceptions/StoppedAuthenticationException.php` (+1 -1) 📝 `composer.json` (+3 -3) 📝 `composer.lock` (+165 -173) ➖ `tests/ActivityTrackingTest.php` (+0 -37) 📝 `tests/Auth/AuthTest.php` (+144 -264) ➖ `tests/BrowserKitTest.php` (+0 -218) 📝 `tests/Entity/BookShelfTest.php` (+8 -0) 📝 `tests/Entity/BookTest.php` (+157 -1) 📝 `tests/Entity/ChapterTest.php` (+25 -1) ➕ `tests/Entity/EntityAccessTest.php` (+52 -0) ➖ `tests/Entity/EntityTest.php` (+0 -319) ➖ `tests/Entity/MarkdownTest.php` (+0 -53) 📝 `tests/Entity/PageDraftTest.php` (+47 -41) ➕ `tests/Entity/PageEditorTest.php` (+77 -0) 📝 `tests/Entity/PageTest.php` (+84 -16) 📝 `tests/Entity/SortTest.php` (+28 -0) 📝 `tests/Permissions/EntityPermissionsTest.php` (+318 -326) _...and 5 more files_ </details> ### 📄 Description Been slowly doing but just need to get this finally done so we don't have this lying around as we head towards Laravel 8/9. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:24:20 +03:00

OVERLORD closed this issue

2026-02-05 10:24:22 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6092