[PR #2902] [MERGED] Fixed SAML logout for ADFS #6087

New Issue

OVERLORD · 2026-02-05T10:24:14+03:00

OVERLORD commented

2026-02-05 10:24:14 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/2902
Author: @theodor-franke
Created: 8/30/2021
Status: ✅ Merged
Merged: 10/23/2021
Merged by: @ssddanbrown

Base: master ← Head: master

📝 Commits (3)

75749ef Fixed SAML logout for ADFS.
234dd26 Fixes for CodeStyle
07408ec Fixes for CodeStyle vol.2

📊 Changes

3 files changed (+18 additions, -4 deletions)

View changed files

📝 .env.example.complete (+5 -0)
📝 app/Auth/Access/Saml2Service.php (+8 -2)
📝 app/Config/saml2.php (+5 -2)

📄 Description

This PR. adds some options to the .env file for configuring the logout with SAML. It also sets the correct NameId in the logout request.

This PR enables:

Signed Logout SAML-Assertions (default is disabled)
Sets the correct email address in the logout assertion
Enables the encoding of lowercase URLs (default is disabled)
some little tweaks in the logout process so that it works with ADFS (theses changes must be enabled in the .env file, without any changes in the .env file the logout process is not altered.)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/2902 **Author:** [@theodor-franke](https://github.com/theodor-franke) **Created:** 8/30/2021 **Status:** ✅ Merged **Merged:** 10/23/2021 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`75749ef`](https://github.com/BookStackApp/BookStack/commit/75749ef336848269d770f7f3b2bf7c9fb9d42479) Fixed SAML logout for ADFS. - [`234dd26`](https://github.com/BookStackApp/BookStack/commit/234dd26d22478451c17e648cc820fac2db081dff) Fixes for CodeStyle - [`07408ec`](https://github.com/BookStackApp/BookStack/commit/07408ec11243995ef6bfded34d87f455336d9460) Fixes for CodeStyle vol.2 ### 📊 Changes **3 files changed** (+18 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.env.example.complete` (+5 -0) 📝 `app/Auth/Access/Saml2Service.php` (+8 -2) 📝 `app/Config/saml2.php` (+5 -2) </details> ### 📄 Description This PR. adds some options to the .env file for configuring the logout with SAML. It also sets the correct NameId in the logout request. This PR enables: - Signed Logout SAML-Assertions (default is disabled) - Sets the correct email address in the logout assertion - Enables the encoding of lowercase URLs (default is disabled) - some little tweaks in the logout process so that it works with ADFS (theses changes must be enabled in the .env file, without any changes in the .env file the logout process is not altered.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:24:14 +03:00

OVERLORD closed this issue

2026-02-05 10:24:16 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6087