mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-23 11:19:38 +03:00
Unexpected behavior when pasting image into Markdown Editor #605
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Ethanb00 on GitHub (Mar 16, 2018).
Expected Behavior
When I paste an image in the Markdown editor, I expect my cursor to end up at the end of the pasted text.
Current Behavior
When I paste an image into the Markdown editor, the cursor goes to the end and then jumps to the middle when the editor adds:
[domain]/uploads/images/gallery/[YYYY-DD-MMM/scaled-840-0/[filename]The cursor ends up at the 'a' in 'scaled'.
Steps to Reproduce
Using Greenshot, take a screen grab and copy to clipboard. Then paste into the Markdown editor.
@ssddanbrown commented on GitHub (Mar 18, 2018):
Thanks for reporting @Ethanb00. I agree the existing behaviour did not make sense. Behind the scenes the cursor was jumping to the end of the line but this would be for the placeholder image that's shown while your image is uploading. Once the image is uploaded the link is replaced, which is a different length, leaving the cursor in the wrong place.
I've updated this for the next release but instead of setting the cursor to the end of the line it will now be placed within the 'alt' section, between the square brackets since this makes sense to me and I think jumping it to the end may lead to unpredictability when factoring in the placeholder image link. Let me know if you think otherwise though.
@Ethanb00 commented on GitHub (Mar 19, 2018):
Hi @ssddanbrown. Thanks so much for the quick response. I think that setting the cursor to the alt section makes total sense and is a better place to put it for most users.
I appreciate the quick turnaround on this!! Cheers!