[PR #2626] [MERGED] User slugs #6033

Closed
opened 2026-02-05 10:23:06 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/2626
Author: @ssddanbrown
Created: 3/9/2021
Status: Merged
Merged: 3/11/2021
Merged by: @ssddanbrown

Base: masterHead: 2525_add_user_slugs


📝 Commits (5)

  • 3a9caea Started work on user slugs
  • 19d79b6 Started rolling out user slugs to model and core controllers
  • 124c4d0 Updated register paths to include user slugs
  • da929d5 Updates search to use user slugs
  • 3c57cbc Updated testing for user slugs

📊 Changes

18 files changed (+210 additions, -102 deletions)

View changed files

📝 app/Auth/Access/SocialAuthService.php (+1 -1)
📝 app/Auth/User.php (+24 -22)
📝 app/Auth/UserRepo.php (+15 -1)
📝 app/Entities/Models/Entity.php (+4 -3)
📝 app/Entities/Tools/SearchRunner.php (+9 -12)
📝 app/Entities/Tools/SlugGenerator.php (+12 -11)
📝 app/Http/Controllers/Auth/SocialController.php (+5 -8)
📝 app/Http/Controllers/SearchController.php (+0 -3)
📝 app/Http/Controllers/UserController.php (+13 -23)
app/Http/Controllers/UserProfileController.php (+25 -0)
app/Interfaces/Sluggable.php (+23 -0)
📝 database/factories/ModelFactory.php (+3 -1)
database/migrations/2021_03_08_215138_add_user_slug.php (+50 -0)
📝 resources/views/common/header.blade.php (+2 -2)
📝 routes/web.php (+5 -5)
📝 tests/Auth/AuthTest.php (+9 -1)
📝 tests/Entity/EntitySearchTest.php (+4 -3)
📝 tests/User/UserProfileTest.php (+6 -6)

📄 Description

In progress; Closes #2525

Todo

  • Check auto-user-create systems
    • Normal registration
    • Social registration (Inc. Auto-register)
    • LDAP
    • SAML
  • Update user of user_ids in search
  • Update tests
  • Cover additions with testing
  • Plan documentation/release-notes requirements within issue.

Docs/Site Updates

  • Update advanced search page.
  • Note profile URL changes and search syntax changes in upgrade notes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/2626 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 3/9/2021 **Status:** ✅ Merged **Merged:** 3/11/2021 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `2525_add_user_slugs` --- ### 📝 Commits (5) - [`3a9caea`](https://github.com/BookStackApp/BookStack/commit/3a9caea84609c9cf584ba9c15eed5d2a0db5a6d3) Started work on user slugs - [`19d79b6`](https://github.com/BookStackApp/BookStack/commit/19d79b6a0f034ab4f7dbd75d60030d276a0c21de) Started rolling out user slugs to model and core controllers - [`124c4d0`](https://github.com/BookStackApp/BookStack/commit/124c4d077815e9a759ab19badc102505b6356acd) Updated register paths to include user slugs - [`da929d5`](https://github.com/BookStackApp/BookStack/commit/da929d5edcb45f7fad433c8522fc88e32b59520f) Updates search to use user slugs - [`3c57cbc`](https://github.com/BookStackApp/BookStack/commit/3c57cbc567b02a411e90d8988d91bd0f54a3d0a0) Updated testing for user slugs ### 📊 Changes **18 files changed** (+210 additions, -102 deletions) <details> <summary>View changed files</summary> 📝 `app/Auth/Access/SocialAuthService.php` (+1 -1) 📝 `app/Auth/User.php` (+24 -22) 📝 `app/Auth/UserRepo.php` (+15 -1) 📝 `app/Entities/Models/Entity.php` (+4 -3) 📝 `app/Entities/Tools/SearchRunner.php` (+9 -12) 📝 `app/Entities/Tools/SlugGenerator.php` (+12 -11) 📝 `app/Http/Controllers/Auth/SocialController.php` (+5 -8) 📝 `app/Http/Controllers/SearchController.php` (+0 -3) 📝 `app/Http/Controllers/UserController.php` (+13 -23) ➕ `app/Http/Controllers/UserProfileController.php` (+25 -0) ➕ `app/Interfaces/Sluggable.php` (+23 -0) 📝 `database/factories/ModelFactory.php` (+3 -1) ➕ `database/migrations/2021_03_08_215138_add_user_slug.php` (+50 -0) 📝 `resources/views/common/header.blade.php` (+2 -2) 📝 `routes/web.php` (+5 -5) 📝 `tests/Auth/AuthTest.php` (+9 -1) 📝 `tests/Entity/EntitySearchTest.php` (+4 -3) 📝 `tests/User/UserProfileTest.php` (+6 -6) </details> ### 📄 Description In progress; Closes #2525 #### Todo - [x] Check auto-user-create systems - [x] Normal registration - [x] Social registration (Inc. Auto-register) - [x] LDAP - [x] SAML - [x] Update user of user_ids in search - [x] Update tests - [x] Cover additions with testing - [x] Plan documentation/release-notes requirements within issue. ### Docs/Site Updates - [ ] Update advanced search page. - [ ] Note profile URL changes and search syntax changes in upgrade notes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:23:06 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6033