starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-02-07 19:06:05 +03:00
Code Issues 784 Packages Projects Releases 10 Wiki Activity

[PR #2611] [MERGED] Allow uploads of files containing dots in filename #6031

New Issue
Closed
opened 2026-02-05 10:23:01 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 10:23:01 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/2611
Author: @Hecke29
Created: 3/5/2021
Status: ✅ Merged
Merged: 3/15/2021
Merged by: @ssddanbrown

Base: master ← Head: master

📝 Commits (1)

📊 Changes

35 files changed (+25 additions, -42 deletions)

View changed files

📝 app/Http/Controllers/Controller.php (+1 -1)
📝 app/Providers/CustomValidationServiceProvider.php (+0 -5)
📝 app/Uploads/ImageService.php (+12 -1)
📝 resources/lang/ar/validation.php (+0 -1)
📝 resources/lang/bg/validation.php (+0 -1)
📝 resources/lang/cs/validation.php (+0 -1)
📝 resources/lang/da/validation.php (+0 -1)
📝 resources/lang/de/validation.php (+0 -1)
📝 resources/lang/de_informal/validation.php (+0 -1)
📝 resources/lang/en/validation.php (+0 -1)
📝 resources/lang/es/validation.php (+0 -1)
📝 resources/lang/es_AR/validation.php (+0 -1)
📝 resources/lang/fa/validation.php (+0 -1)
📝 resources/lang/fr/validation.php (+0 -1)
📝 resources/lang/he/validation.php (+0 -1)
📝 resources/lang/hu/validation.php (+0 -1)
📝 resources/lang/it/validation.php (+0 -1)
📝 resources/lang/ja/validation.php (+0 -1)
📝 resources/lang/ko/validation.php (+0 -1)
📝 resources/lang/nb/validation.php (+0 -1)

...and 15 more files

📄 Description

When I take screenshots on my MacBook it will create a file that contains the time with dots separated; e.g. Bildschirmfoto 2021-03-04 um 18.29.58.
I could never upload them directly to BookStack (that I use and recommend with multiple clients) but had to rename them before and today was the evening I want to change that.

Closes #2217

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/2611 **Author:** [@Hecke29](https://github.com/Hecke29) **Created:** 3/5/2021 **Status:** ✅ Merged **Merged:** 3/15/2021 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`745d15d`](https://github.com/BookStackApp/BookStack/commit/745d15d200dc9df5761eb77616575bc15eefb537) Allow uploads of files containing dots in filename. Closes BookStackApp/BookStack#2217 ### 📊 Changes **35 files changed** (+25 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/Controller.php` (+1 -1) 📝 `app/Providers/CustomValidationServiceProvider.php` (+0 -5) 📝 `app/Uploads/ImageService.php` (+12 -1) 📝 `resources/lang/ar/validation.php` (+0 -1) 📝 `resources/lang/bg/validation.php` (+0 -1) 📝 `resources/lang/cs/validation.php` (+0 -1) 📝 `resources/lang/da/validation.php` (+0 -1) 📝 `resources/lang/de/validation.php` (+0 -1) 📝 `resources/lang/de_informal/validation.php` (+0 -1) 📝 `resources/lang/en/validation.php` (+0 -1) 📝 `resources/lang/es/validation.php` (+0 -1) 📝 `resources/lang/es_AR/validation.php` (+0 -1) 📝 `resources/lang/fa/validation.php` (+0 -1) 📝 `resources/lang/fr/validation.php` (+0 -1) 📝 `resources/lang/he/validation.php` (+0 -1) 📝 `resources/lang/hu/validation.php` (+0 -1) 📝 `resources/lang/it/validation.php` (+0 -1) 📝 `resources/lang/ja/validation.php` (+0 -1) 📝 `resources/lang/ko/validation.php` (+0 -1) 📝 `resources/lang/nb/validation.php` (+0 -1) _...and 15 more files_ </details> ### 📄 Description When I take screenshots on my MacBook it will create a file that contains the time with dots separated; e.g. `Bildschirmfoto 2021-03-04 um 18.29.58`. I could never upload them directly to BookStack (that I use and recommend with multiple clients) but had to rename them before and today was the evening I want to change that. Closes #2217 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:23:01 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#6031
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?