[PR #2475] [CLOSED] Made ApiController non-abstract #6006

New Issue

OVERLORD · 2026-02-05T10:22:20+03:00

OVERLORD commented

2026-02-05 10:22:20 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/2475
Author: @gertjankrol
Created: 1/11/2021
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

b0c52bb Make ApiController non-abstract

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 app/Http/Controllers/Api/ApiController.php (+2 -2)

📄 Description

This fixes php artisan route:list (controllers can't be abstract because then they're not instantiable)
I haven't tested the full API functionality, as I don't use this (yet). I don't think this will cause any problems though.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/2475 **Author:** [@gertjankrol](https://github.com/gertjankrol) **Created:** 1/11/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`b0c52bb`](https://github.com/BookStackApp/BookStack/commit/b0c52bbbe057101b49efe2dde6a3689c3cb3786c) Make `ApiController` non-abstract ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/Api/ApiController.php` (+2 -2) </details> ### 📄 Description This fixes `php artisan route:list` (controllers can't be abstract because then they're not instantiable) I haven't tested the full API functionality, as I don't use this (yet). I don't think this will cause any problems though. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:22:20 +03:00

OVERLORD closed this issue

2026-02-05 10:22:22 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6006

[PR #2475] [CLOSED] Made ApiController non-abstract #6006

📋 Pull Request Information

📝 Commits (1)

📊 Changes

📄 Description

[PR #2475] [CLOSED] Made `ApiController` non-abstract #6006