[PR #2487] [MERGED] Show tags of all search results #6003

New Issue

OVERLORD · 2026-02-05T10:22:18+03:00

OVERLORD commented

2026-02-05 10:22:18 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/2487
Author: @burnoutberni
Created: 1/15/2021
Status: ✅ Merged
Merged: 5/24/2021
Merged by: @ssddanbrown

Base: master ← Head: show-tags

📝 Commits (1)

aad2ee6 Show tags of all search results

📊 Changes

6 files changed (+14 additions, -6 deletions)

View changed files

📝 resources/sass/_blocks.scss (+1 -1)
📝 resources/views/components/tag-list.blade.php (+7 -2)
📝 resources/views/partials/entity-list-item-basic.blade.php (+3 -0)
📝 resources/views/partials/entity-list-item.blade.php (+1 -1)
📝 resources/views/partials/entity-list.blade.php (+1 -1)
📝 resources/views/search/all.blade.php (+1 -1)

📄 Description

This is a basic implementation of #2462.

It's rather similar to the $showPath property that you can attach to any entity-list. Now there's another property called $showTags that adds all tags to the list items. I've only enabled it for the search results page, but this might come in handy in other circumstances too.

Obviously the search results link to the corresponding shelf/book/chapter/page, but the tags also contain links. This is an issue since nesting <a> elements is not allowed. To avoid this I've added a $disableLinks property to tag-list, which replaces the tag links with <span> elements.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/2487 **Author:** [@burnoutberni](https://github.com/burnoutberni) **Created:** 1/15/2021 **Status:** ✅ Merged **Merged:** 5/24/2021 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `show-tags` --- ### 📝 Commits (1) - [`aad2ee6`](https://github.com/BookStackApp/BookStack/commit/aad2ee675caffbe095391e505d2c980953761d25) Show tags of all search results ### 📊 Changes **6 files changed** (+14 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `resources/sass/_blocks.scss` (+1 -1) 📝 `resources/views/components/tag-list.blade.php` (+7 -2) 📝 `resources/views/partials/entity-list-item-basic.blade.php` (+3 -0) 📝 `resources/views/partials/entity-list-item.blade.php` (+1 -1) 📝 `resources/views/partials/entity-list.blade.php` (+1 -1) 📝 `resources/views/search/all.blade.php` (+1 -1) </details> ### 📄 Description This is a basic implementation of #2462. It's rather similar to the `$showPath` property that you can attach to any `entity-list`. Now there's another property called `$showTags` that adds all tags to the list items. I've only enabled it for the search results page, but this might come in handy in other circumstances too. Obviously the search results link to the corresponding shelf/book/chapter/page, but the tags also contain links. This is an issue since nesting `<a>` elements is not allowed. To avoid this I've added a `$disableLinks` property to `tag-list`, which replaces the tag links with `<span>` elements. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:22:18 +03:00

OVERLORD closed this issue

2026-02-05 10:22:22 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#6003