[PR #2410] [CLOSED] PHP 8 Support #5994

New Issue

OVERLORD · 2026-02-05T10:22:04+03:00

OVERLORD commented

2026-02-05 10:22:04 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/2410
Author: @ssddanbrown
Created: 12/13/2020
Status: ❌ Closed

Base: master ← Head: php8

📝 Commits (1)

354b167 Done initial run-though of deps for php8

📊 Changes

1 file changed (+22 additions, -23 deletions)

View changed files

📝 composer.json (+22 -23)

📄 Description

Outstanding dependency issues

doctrine/dbal
- PHP8 support added in 2.12+, PHP7.2 dropped from 2.11+
- Support across same stable version, could or the versions.
onelogin/php-saml
- Current lacks PHP8 support, Mentioned here.
fzaninotto/faker (Dev)
- Think we'll need to look to use https://github.com/fakerphp/faker instead. Check against current Laravel defaults for v6 & latest branches.
phpunit/phpunit (Dev)
- 8.5 installable but not full supported (No code coverage) on PHP8. 9.x branch does support php 8 but requires 7.3.
- Could or the versions here.

Other Considerations

Have removed laravel-stats package due to lack of use and change of license terms that I'm not confident we can meet.
I think we'll need to remove the config.platform option in composer.json to ensure PHP 8+ systems and PHP 7 get their supported packages.
Will we have to remove the composer.lock file? Since now we're likely to see different dependencies per platform? If so, Will need to double check versions in composer.json are accurately locked. May also lead to some instability or future unexpected problems, especially as user installs may be harder to replicate.
- If removed we'd then need to change how updates are done since a composer update may be needed from second update onwards, due to a local non-changing composer.lock file.
Could it be easier to do an extra php version change for BookStack, to get us past this. Jump to php7.4 soon. Might be worth seeing what Laravel is jumping to for next LTS then align sooner than expected.

Closes #2388

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/2410 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 12/13/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `php8` --- ### 📝 Commits (1) - [`354b167`](https://github.com/BookStackApp/BookStack/commit/354b167fe38ea14da99d01635aeb9c2623836da1) Done initial run-though of deps for php8 ### 📊 Changes **1 file changed** (+22 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `composer.json` (+22 -23) </details> ### 📄 Description #### Outstanding dependency issues * doctrine/dbal * PHP8 support added in 2.12+, PHP7.2 dropped from 2.11+ * Support across same stable version, could `or` the versions. * onelogin/php-saml * Current lacks PHP8 support, [Mentioned here](https://github.com/onelogin/php-saml/issues/453). * fzaninotto/faker (Dev) * Think we'll need to look to use https://github.com/fakerphp/faker instead. Check against current Laravel defaults for v6 & latest branches. * phpunit/phpunit (Dev) * 8.5 installable but not full supported (No code coverage) on PHP8. 9.x branch does support php 8 but requires 7.3. * Could `or` the versions here. #### Other Considerations * Have removed laravel-stats package due to lack of use and change of license terms that I'm not confident we can meet. * I think we'll need to remove the `config.platform` option in `composer.json` to ensure PHP 8+ systems and PHP 7 get their supported packages. * Will we have to remove the composer.lock file? Since now we're likely to see different dependencies per platform? If so, Will need to double check versions in composer.json are accurately locked. May also lead to some instability or future unexpected problems, especially as user installs may be harder to replicate. * If removed we'd then need to change how updates are done since a `composer update` may be needed from second update onwards, due to a local non-changing composer.lock file. * Could it be easier to do an extra php version change for BookStack, to get us past this. Jump to php7.4 soon. Might be worth seeing what Laravel is jumping to for next LTS then align sooner than expected. --- Closes #2388 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:22:04 +03:00

OVERLORD closed this issue

2026-02-05 10:22:05 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5994