mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Installing with --no-dev fails #598
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @lommes on GitHub (Mar 12, 2018).
When you try to install BookStack with
composer install --no-devthis will fail since some packages like barryvdh/laravel-ide-helper are not installed, but expected in config/app.php.Installing with the no-dev option is a thing often used by deployment-systems. I use deployer and have to override some solid defaults to make it work. Also composer might change the way how they deal with packages in require-dev and only load require packages by default.
If the package is required for running BookStack it should be included in the required section. Are the entries in app.php still required or are these packages already using autodiscovery (at least laravel-ide-helper does)? If so, we can remove them.
@ssddanbrown commented on GitHub (Mar 12, 2018):
@lommes Yeah, I totally agree with the above.
It looks like all the third party providers have auto-discovery but I know for the PDF libs and Intervention I used non-default aliases/Facades since the defaults are very generic and could get confused with other classes. Not sure if that will have an impact and how auto-discovery works there.
@ssddanbrown commented on GitHub (Mar 18, 2018):
Just pushed
c6844324d0to cover this.I've left the non-dev service providers in there as it's nice to be able to see all required app service providers used listed in one place.