[PR #2298] [MERGED] Install composer dependencies in Docker entrypoint #5976

Closed
opened 2026-02-05 10:21:41 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/2298
Author: @timoschwarzer
Created: 10/1/2020
Status: Merged
Merged: 11/1/2020
Merged by: @ssddanbrown

Base: masterHead: composer-install-in-entrypoint


📝 Commits (1)

  • a74d551 Install composer dependencies in Docker entrypoint

📊 Changes

2 files changed (+8 additions, -8 deletions)

View changed files

📝 dev/docker/entrypoint.app.sh (+2 -1)
📝 readme.md (+6 -7)

📄 Description

I think it is an unnecessary step to install composer dependencies manually when using the Docker development environment. NPM dependencies also get installed automatically so this is just one less thing to think of :)

I also noted that you need to set APP_ENV to local because database migrations won't run otherwise. (Command is skipped in production)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/2298 **Author:** [@timoschwarzer](https://github.com/timoschwarzer) **Created:** 10/1/2020 **Status:** ✅ Merged **Merged:** 11/1/2020 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `composer-install-in-entrypoint` --- ### 📝 Commits (1) - [`a74d551`](https://github.com/BookStackApp/BookStack/commit/a74d551bd6428ccc73098d53cc7ec8de79b0d6b2) Install composer dependencies in Docker entrypoint ### 📊 Changes **2 files changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `dev/docker/entrypoint.app.sh` (+2 -1) 📝 `readme.md` (+6 -7) </details> ### 📄 Description I think it is an unnecessary step to install composer dependencies manually when using the Docker development environment. NPM dependencies also get installed automatically so this is just one less thing to think of :) I also noted that you need to set `APP_ENV` to `local` because database migrations won't run otherwise. (Command is skipped in production) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:21:41 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5976