[PR #2296] [MERGED] Fix build:js:watch not building at first launch in Docker #5972

Closed
opened 2026-02-05 10:21:39 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/2296
Author: @timoschwarzer
Created: 10/1/2020
Status: Merged
Merged: 10/14/2020
Merged by: @ssddanbrown

Base: masterHead: esbuild-watch-first-time-fix


📝 Commits (1)

  • aca37b8 Fix build:js:watch not building at first launch in Docker

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 dev/docker/entrypoint.node.sh (+1 -1)
📝 package.json (+1 -1)

📄 Description

This PR adds the --initial flag to chokidar. This ensures that the JS resources get built immediately after starting the build:js:watch script. I also passed the SHELL environment variable down to node in the node entrypoint because chokidar does not run without it.

tl;dr: this makes it possible again to clone the repository, follow the Docker steps in the README and having a working dev installation after that :)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/2296 **Author:** [@timoschwarzer](https://github.com/timoschwarzer) **Created:** 10/1/2020 **Status:** ✅ Merged **Merged:** 10/14/2020 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `esbuild-watch-first-time-fix` --- ### 📝 Commits (1) - [`aca37b8`](https://github.com/BookStackApp/BookStack/commit/aca37b87842a93d6b7572c939f06bc7899c89ce9) Fix build:js:watch not building at first launch in Docker ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `dev/docker/entrypoint.node.sh` (+1 -1) 📝 `package.json` (+1 -1) </details> ### 📄 Description This PR adds the `--initial` flag to `chokidar`. This ensures that the JS resources get built immediately after starting the `build:js:watch` script. I also passed the `SHELL` environment variable down to node in the node entrypoint because `chokidar` does not run without it. tl;dr: this makes it possible again to clone the repository, follow the Docker steps in the README and having a working dev installation after that :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:21:39 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5972