[PR #2268] [MERGED] Fix the AddActivityIndexes migration's down() method #5962

Closed
opened 2026-02-05 10:21:28 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/2268
Author: @gertjankrol
Created: 9/22/2020
Status: Merged
Merged: 9/26/2020
Merged by: @ssddanbrown

Base: masterHead: master


📝 Commits (1)

  • 4b0d1dd Fixed the AddActivityIndexes migration's down() method

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 database/migrations/2020_09_19_094251_add_activity_indexes.php (+2 -2)

📄 Description

This PR fixes artisan migration:rollback, which was broken due to incorrect index names in the 2020_09_19_094251_add_activity_indexes migration:

SQLSTATE[42000]: Syntax error or access violation: 1091 Can't DROP INDEX `key`; check that it exists (SQL: alter table `activities` drop index `key`)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/2268 **Author:** [@gertjankrol](https://github.com/gertjankrol) **Created:** 9/22/2020 **Status:** ✅ Merged **Merged:** 9/26/2020 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`4b0d1dd`](https://github.com/BookStackApp/BookStack/commit/4b0d1ddf39ff9e387455add2778db3204eea582f) Fixed the `AddActivityIndexes` migration's `down()` method ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `database/migrations/2020_09_19_094251_add_activity_indexes.php` (+2 -2) </details> ### 📄 Description This PR fixes `artisan migration:rollback`, which was broken due to incorrect index names in the `2020_09_19_094251_add_activity_indexes` migration: ``` SQLSTATE[42000]: Syntax error or access violation: 1091 Can't DROP INDEX `key`; check that it exists (SQL: alter table `activities` drop index `key`) ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:21:28 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5962