starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-05-04 18:08:46 +03:00
Code Issues 784 Packages Projects Releases 15 Wiki Activity

[PR #2214] [CLOSED] fix test errors of comment 87a5340 #5961

New Issue
Closed
opened 2026-02-05 10:21:24 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 10:21:24 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/2214
Author: @tomleesm
Created: 8/6/2020
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (10+)

  • 40307ca Merge pull request #4 from BookStackApp/master
  • e933f91 fix previous test errors
  • f99dccb Merge pull request #5 from tomleesm/fix-test-error-register-confirm-awaiting
  • 0ca5434 extract method getPageNumber() to get page number
  • be1db96 Merge pull request #6 from tomleesm/refactor-search
  • 68e49dd extract method getNextPageNumber(): make code clear
  • 9fe4b5b extract method getNextPageLink()
  • 69edb6d Merge pull request #7 from tomleesm/refactor-entity-search
  • 195990b Merge pull request #8 from tomleesm/refactor-entity-search
  • 41cb398 extract method getEntityTypesToSearch()

📊 Changes

3 files changed (+63 additions, -38 deletions)

View changed files

📝 app/Entities/SearchService.php (+34 -30)
📝 app/Http/Controllers/SearchController.php (+22 -5)
📝 tests/Auth/AuthTest.php (+7 -3)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/2214 **Author:** [@tomleesm](https://github.com/tomleesm) **Created:** 8/6/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`40307ca`](https://github.com/BookStackApp/BookStack/commit/40307cabf3c99634e29a68e43c7e09a4b719765e) Merge pull request #4 from BookStackApp/master - [`e933f91`](https://github.com/BookStackApp/BookStack/commit/e933f915c82dcab6829448e98ed6c5033fb54804) fix previous test errors - [`f99dccb`](https://github.com/BookStackApp/BookStack/commit/f99dccb4f8a0efd0cfe51bd28b35ecc3c459b87e) Merge pull request #5 from tomleesm/fix-test-error-register-confirm-awaiting - [`0ca5434`](https://github.com/BookStackApp/BookStack/commit/0ca5434777ccebf1fdaa99333cf79c0a73e1649f) extract method getPageNumber() to get page number - [`be1db96`](https://github.com/BookStackApp/BookStack/commit/be1db96fd0841365c0c509878ba7cf148fc65e5b) Merge pull request #6 from tomleesm/refactor-search - [`68e49dd`](https://github.com/BookStackApp/BookStack/commit/68e49dd126b72bcfe5b96a63ae321c28d3874ff0) extract method getNextPageNumber(): make code clear - [`9fe4b5b`](https://github.com/BookStackApp/BookStack/commit/9fe4b5bbc248ac15696425c4ec688d876a96ec14) extract method getNextPageLink() - [`69edb6d`](https://github.com/BookStackApp/BookStack/commit/69edb6dc7feb4c485ce7b5045d6f4c5044bf61c8) Merge pull request #7 from tomleesm/refactor-entity-search - [`195990b`](https://github.com/BookStackApp/BookStack/commit/195990b83a573d99aefc7fc8c981de175416b2cd) Merge pull request #8 from tomleesm/refactor-entity-search - [`41cb398`](https://github.com/BookStackApp/BookStack/commit/41cb398e2536e1a4de188e2e67e816cb285665b2) extract method getEntityTypesToSearch() ### 📊 Changes **3 files changed** (+63 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `app/Entities/SearchService.php` (+34 -30) 📝 `app/Http/Controllers/SearchController.php` (+22 -5) 📝 `tests/Auth/AuthTest.php` (+7 -3) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:21:24 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5961
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?