[PR #2227] [MERGED] Render included content when exporting books #5958

New Issue

OVERLORD · 2026-02-05T10:21:23+03:00

OVERLORD commented

2026-02-05 10:21:23 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/2227
Author: @mr-vinn
Created: 8/15/2020
Status: ✅ Merged
Merged: 9/26/2020
Merged by: @ssddanbrown

Base: master ← Head: renderpages

📝 Commits (1)

2c3f453 Implement the renderPages parameter

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 app/Entities/Managers/BookContents.php (+5 -2)

📄 Description

Currently, if I create a page with included content ({{@123}}) then I see the rendered content when I export the page or its containing chapter. But the book export prints the literal string {{@123}} in the output instead of the included content.

This change results in the included content being rendered no matter which object (book, chapter, page) is exported.

Fixes #2228

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/2227 **Author:** [@mr-vinn](https://github.com/mr-vinn) **Created:** 8/15/2020 **Status:** ✅ Merged **Merged:** 9/26/2020 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `renderpages` --- ### 📝 Commits (1) - [`2c3f453`](https://github.com/BookStackApp/BookStack/commit/2c3f453c1fa2b2933a10906228203a13c6d42ed2) Implement the renderPages parameter ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/Entities/Managers/BookContents.php` (+5 -2) </details> ### 📄 Description Currently, if I create a page with included content (`{{@123}}`) then I see the rendered content when I export the page or its containing chapter. But the book export prints the literal string `{{@123}}` in the output instead of the included content. This change results in the included content being rendered no matter which object (book, chapter, page) is exported. Fixes #2228 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:21:23 +03:00

OVERLORD closed this issue

2026-02-05 10:21:25 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5958