[PR #2184] [CLOSED] Feature - Convert Code Language to Select instead of Links + Input #5956

Closed
opened 2026-02-05 10:21:17 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/2184
Author: @b-zurg
Created: 7/10/2020
Status: Closed

Base: masterHead: add-typescript-formatting


📝 Commits (4)

  • c84896c feat: Add code block support for typescript, jsx, tsx
  • 65943f5 fix: docker-compose not running unless env variable set
  • dc0858d fix: Reverting .env.example in favour of putting the env variable in docker-compose
  • 4895049 feat: Change language select to dropdown

📊 Changes

5 files changed (+52 additions, -41 deletions)

View changed files

📝 .gitattributes (+1 -1)
📝 docker-compose.yml (+1 -0)
📝 resources/js/components/code-editor.js (+11 -10)
📝 resources/js/services/code.js (+8 -3)
📝 resources/views/components/code-editor.blade.php (+31 -27)

📄 Description

Description

Converted the language select in the code editor to be a dropdown instead of a link select and free-text input field. This is a common pattern for this UI element and makes a lot of sense for a code language.

Added language support for TypeScript and JSX/TSX to allow for React and Typescript documentation.

Added a change that would ensure that the line-endings are LF (for windows developers) to not have an issue with the developer docker setup.

Added an environment variable APP_ENV to docker-compose as it was necessary for my development environment to run.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/2184 **Author:** [@b-zurg](https://github.com/b-zurg) **Created:** 7/10/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `add-typescript-formatting` --- ### 📝 Commits (4) - [`c84896c`](https://github.com/BookStackApp/BookStack/commit/c84896cf9de2d89425b5484ccbcdeb29468a3f08) feat: Add code block support for typescript, jsx, tsx - [`65943f5`](https://github.com/BookStackApp/BookStack/commit/65943f567db98a35d93798513980d671288d1f45) fix: docker-compose not running unless env variable set - [`dc0858d`](https://github.com/BookStackApp/BookStack/commit/dc0858de12cb7a20d0ec2ccab2b832a95787a233) fix: Reverting .env.example in favour of putting the env variable in docker-compose - [`4895049`](https://github.com/BookStackApp/BookStack/commit/48950490f4724c7265a717789d5500160a7851d3) feat: Change language select to dropdown ### 📊 Changes **5 files changed** (+52 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `.gitattributes` (+1 -1) 📝 `docker-compose.yml` (+1 -0) 📝 `resources/js/components/code-editor.js` (+11 -10) 📝 `resources/js/services/code.js` (+8 -3) 📝 `resources/views/components/code-editor.blade.php` (+31 -27) </details> ### 📄 Description Description Converted the language select in the code editor to be a dropdown instead of a link select and free-text input field. This is a common pattern for this UI element and makes a lot of sense for a code language. Added language support for TypeScript and JSX/TSX to allow for React and Typescript documentation. Added a change that would ensure that the line-endings are LF (for windows developers) to not have an issue with the developer docker setup. Added an environment variable `APP_ENV` to docker-compose as it was necessary for my development environment to run. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:21:17 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5956