[PR #2166] [MERGED] Replace node-sass with dart-sass #5952

New Issue

OVERLORD · 2026-02-05T10:21:13+03:00

OVERLORD commented

2026-02-05 10:21:13 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/2166
Author: @timoschwarzer
Created: 6/26/2020
Status: ✅ Merged
Merged: 6/27/2020
Merged by: @ssddanbrown

Base: master ← Head: use-dart-sass

📝 Commits (1)

0f55d77 Replace node-sass with dart-sass

📊 Changes

3 files changed (+10 additions, -1080 deletions)

View changed files

📝 package-lock.json (+7 -1077)
📝 package.json (+1 -1)
📝 resources/sass/_spacing.scss (+2 -2)

📄 Description

This PR replaces node-sass with sass. sass is the SASS/SCSS reference implementation.

Pros:

No native dependencies (JS only)
Faster availability of new features

Cons:

A bit slower, but not very noticable.

Why?

node-sass broke again for me with Node 14 with some error that it couldn't download some binaries from GitHub.

node_1     | Downloading binary from https://github.com/sass/node-sass/releases/download/v4.13.1/linux_musl-x64-83_binding.node
node_1     | Cannot download "https://github.com/sass/node-sass/releases/download/v4.13.1/linux_musl-x64-83_binding.node": 
node_1     | 
node_1     | HTTP error 404 Not Found
node_1     | 
node_1     | Hint: If github.com is not accessible in your location
node_1     |       try setting a proxy via HTTP_PROXY, e.g. 
node_1     | 
node_1     |       export HTTP_PROXY=http://example.com:1234
node_1     | 
node_1     | or configure npm proxy via
node_1     | 
node_1     |       npm config set proxy http://example.com:8080
node_1     | 
node_1     | > node-sass@4.13.1 postinstall /app/node_modules/node-sass
node_1     | > node scripts/build.js

Issues like the above or https://github.com/BookStackApp/BookStack/issues/1820 shouldn't arise anymore with sass.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/2166 **Author:** [@timoschwarzer](https://github.com/timoschwarzer) **Created:** 6/26/2020 **Status:** ✅ Merged **Merged:** 6/27/2020 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `use-dart-sass` --- ### 📝 Commits (1) - [`0f55d77`](https://github.com/BookStackApp/BookStack/commit/0f55d776a6e4b072b75e704ac56e4b138bfa47f8) Replace node-sass with dart-sass ### 📊 Changes **3 files changed** (+10 additions, -1080 deletions) <details> <summary>View changed files</summary> 📝 `package-lock.json` (+7 -1077) 📝 `package.json` (+1 -1) 📝 `resources/sass/_spacing.scss` (+2 -2) </details> ### 📄 Description This PR replaces `node-sass` with `sass`. `sass` is the [SASS/SCSS reference implementation](https://github.com/sass/dart-sass). ### Pros: - No native dependencies (JS only) - Faster availability of new features ### Cons: - A bit slower, but not very noticable. ### Why? `node-sass` broke again for me with Node 14 with some error that it couldn't download some binaries from GitHub. ``` node_1 | Downloading binary from https://github.com/sass/node-sass/releases/download/v4.13.1/linux_musl-x64-83_binding.node node_1 | Cannot download "https://github.com/sass/node-sass/releases/download/v4.13.1/linux_musl-x64-83_binding.node": node_1 | node_1 | HTTP error 404 Not Found node_1 | node_1 | Hint: If github.com is not accessible in your location node_1 | try setting a proxy via HTTP_PROXY, e.g. node_1 | node_1 | export HTTP_PROXY=http://example.com:1234 node_1 | node_1 | or configure npm proxy via node_1 | node_1 | npm config set proxy http://example.com:8080 node_1 | node_1 | > node-sass@4.13.1 postinstall /app/node_modules/node-sass node_1 | > node scripts/build.js ``` Issues like the above or https://github.com/BookStackApp/BookStack/issues/1820 shouldn't arise anymore with `sass`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:21:13 +03:00

OVERLORD closed this issue

2026-02-05 10:21:14 +03:00

OVERLORD referenced this issue

2026-02-05 10:36:32 +03:00

[PR #5952] [MERGED] Update "Microsoft URL Rewrite Module for IIS" download link #6604

Sign in to join this conversation.