[PR #1973] [MERGED] Create footer for regulatory links #5931

New Issue

OVERLORD · 2026-02-05T10:20:39+03:00

OVERLORD commented

2026-02-05 10:20:39 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1973
Author: @james-geiger
Created: 3/19/2020
Status: ✅ Merged
Merged: 1/31/2021
Merged by: @ssddanbrown

Base: master ← Head: footer-links

📝 Commits (1)

fe438bd Add footer element, styles, and associated settings

📊 Changes

8 files changed (+56 additions, -0 deletions)

View changed files

📝 resources/lang/en/settings.php (+4 -0)
➕ resources/sass/_footer.scss (+17 -0)
📝 resources/sass/_html.scss (+3 -0)
📝 resources/sass/_layout.scss (+4 -0)
📝 resources/sass/styles.scss (+1 -0)
📝 resources/views/base.blade.php (+2 -0)
➕ resources/views/common/footer.blade.php (+10 -0)
📝 resources/views/settings/index.blade.php (+15 -0)

📄 Description

Per #854 and feedback from @ApertureDevelopment, provides a mechanism to add links to a privacy policy and terms of service from the settings page.

Currently would not display on the page editor pages, but am open to and welcome feedback. It just didn't seem to me to fit the flow very well with the full-page editor, but this could also be added as a setting as well.

@ssddanbrown, not sure what your thoughts are on limits to the number of "app settings" but this seemed like it would be a good fit for that section. Also purposely limited this to two different kinds of links. Could likely be abstracted into a feature where you could add any number of "custom footer links" each with a label and href, but this seemed like a good place to start.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1973 **Author:** [@james-geiger](https://github.com/james-geiger) **Created:** 3/19/2020 **Status:** ✅ Merged **Merged:** 1/31/2021 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `footer-links` --- ### 📝 Commits (1) - [`fe438bd`](https://github.com/BookStackApp/BookStack/commit/fe438bdb4537e621ca3e9f92256c11fa5a7dbb85) Add footer element, styles, and associated settings ### 📊 Changes **8 files changed** (+56 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `resources/lang/en/settings.php` (+4 -0) ➕ `resources/sass/_footer.scss` (+17 -0) 📝 `resources/sass/_html.scss` (+3 -0) 📝 `resources/sass/_layout.scss` (+4 -0) 📝 `resources/sass/styles.scss` (+1 -0) 📝 `resources/views/base.blade.php` (+2 -0) ➕ `resources/views/common/footer.blade.php` (+10 -0) 📝 `resources/views/settings/index.blade.php` (+15 -0) </details> ### 📄 Description Per #854 and feedback from @ApertureDevelopment, provides a mechanism to add links to a privacy policy and terms of service from the settings page. Currently would not display on the page editor pages, but am open to and welcome feedback. It just didn't seem to me to fit the flow very well with the full-page editor, but this could also be added as a setting as well. @ssddanbrown, not sure what your thoughts are on limits to the number of "app settings" but this seemed like it would be a good fit for that section. Also purposely limited this to two different kinds of links. Could likely be abstracted into a feature where you could add any number of "custom footer links" each with a label and href, but this seemed like a good place to start. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:20:39 +03:00

OVERLORD closed this issue

2026-02-05 10:20:42 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5931