[PR #1900] [MERGED] Validation fixes #5921

New Issue

OVERLORD · 2026-02-05T10:20:25+03:00

OVERLORD commented

2026-02-05 10:20:25 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1900
Author: @TBK
Created: 2/15/2020
Status: ✅ Merged
Merged: 3/14/2020
Merged by: @ssddanbrown

Base: master ← Head: validation_fixes

📝 Commits (3)

5cd56f6 Change check to verify that request is present and contains a file
d3737d5 Remove redundant getImageValidationRules method
57f587a Allow book, shelf, settings & profile form input validation to skip image

📊 Changes

6 files changed (+9 additions, -17 deletions)

View changed files

📝 app/Http/Controllers/BookController.php (+2 -2)
📝 app/Http/Controllers/BookshelfController.php (+2 -2)
📝 app/Http/Controllers/Images/GalleryImageController.php (+1 -1)
📝 app/Http/Controllers/SettingController.php (+2 -2)
📝 app/Http/Controllers/UserController.php (+2 -2)
📝 app/Uploads/ImageRepo.php (+0 -8)

📄 Description

Fix to #1570

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1900 **Author:** [@TBK](https://github.com/TBK) **Created:** 2/15/2020 **Status:** ✅ Merged **Merged:** 3/14/2020 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `validation_fixes` --- ### 📝 Commits (3) - [`5cd56f6`](https://github.com/BookStackApp/BookStack/commit/5cd56f63ff7b31abe0901ebea8931a70a5e4994c) Change check to verify that request is present and contains a file - [`d3737d5`](https://github.com/BookStackApp/BookStack/commit/d3737d5a879ca7284ff7e6170264cfe99ed2a4b5) Remove redundant getImageValidationRules method - [`57f587a`](https://github.com/BookStackApp/BookStack/commit/57f587a78b47b23fc646b621628a834833826d69) Allow book, shelf, settings & profile form input validation to skip image ### 📊 Changes **6 files changed** (+9 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/BookController.php` (+2 -2) 📝 `app/Http/Controllers/BookshelfController.php` (+2 -2) 📝 `app/Http/Controllers/Images/GalleryImageController.php` (+1 -1) 📝 `app/Http/Controllers/SettingController.php` (+2 -2) 📝 `app/Http/Controllers/UserController.php` (+2 -2) 📝 `app/Uploads/ImageRepo.php` (+0 -8) </details> ### 📄 Description Fix to #1570 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:20:26 +03:00

OVERLORD closed this issue

2026-02-05 10:20:26 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5921