[PR #1743] [CLOSED] Bugfix - takes APP_URL on redirect after login into account. Fixes issue #1377 #5879

New Issue

OVERLORD · 2026-02-05T10:19:19+03:00

OVERLORD commented

2026-02-05 10:19:19 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1743
Author: @philjak
Created: 10/25/2019
Status: ❌ Closed

Base: master ← Head: bugfix_login_redirect_reverseproxy

📝 Commits (4)

fa918f4 Takes APP_URL on redirect after login into account. Fixes issue #1377
6d07531 Check if APP_URL variable is set
82b260f Check if APP_URL variable is set
38e4f97 Check if parsing of APP_URL is possible

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 app/Http/Controllers/Auth/LoginController.php (+5 -1)

📄 Description

This PR strips the path of the APP_URL from the wrong url.intended string. This causes a correct redirect after login no matter if the APP_URL variable is set or not.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1743 **Author:** [@philjak](https://github.com/philjak) **Created:** 10/25/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `bugfix_login_redirect_reverseproxy` --- ### 📝 Commits (4) - [`fa918f4`](https://github.com/BookStackApp/BookStack/commit/fa918f49d6cdf647a43d4b2716af048b8ad4fffc) Takes APP_URL on redirect after login into account. Fixes issue #1377 - [`6d07531`](https://github.com/BookStackApp/BookStack/commit/6d075316f126ca2ce174efe1e22d065180a83fb0) Check if APP_URL variable is set - [`82b260f`](https://github.com/BookStackApp/BookStack/commit/82b260f0845da2e7c771bde5451e27238c5b2c49) Check if APP_URL variable is set - [`38e4f97`](https://github.com/BookStackApp/BookStack/commit/38e4f97d8ae81e71ed8f9de4cdb2d97addd2f27a) Check if parsing of APP_URL is possible ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/Auth/LoginController.php` (+5 -1) </details> ### 📄 Description This PR strips the path of the APP_URL from the wrong url.intended string. This causes a correct redirect after login no matter if the APP_URL variable is set or not. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:19:19 +03:00

OVERLORD closed this issue

2026-02-05 10:19:22 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5879