[PR #1688] [MERGED] Show list of bookshelves that a book belongs to on a book view #5865

Closed
opened 2026-02-05 10:18:59 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1688
Author: @cnfw
Created: 9/27/2019
Status: Merged
Merged: 4/9/2020
Merged by: @ssddanbrown

Base: masterHead: feature/#1598


📝 Commits (1)

  • 4ad4dfa Show bookshelves that a book belongs to on a book view

📊 Changes

5 files changed (+52 additions, -3 deletions)

View changed files

📝 app/Entities/Repos/EntityRepo.php (+11 -0)
📝 app/Http/Controllers/BookController.php (+2 -0)
📝 resources/lang/en/entities.php (+1 -0)
📝 resources/views/books/show.blade.php (+10 -3)
📝 tests/Entity/BookShelfTest.php (+28 -0)

📄 Description

Closes #1598
I put these underneath actions because there could potentially be many that push the actions off-screen. But you will likely want to change the placement of this if this is a feature you wish to merge 👍

Another part of this PR to look out for is the heading above the list. I went with Bookshelves because I think it should be clear enough from the context (a book) that it is referring to the bookshelves that the book can be found on.

Thanks

image
image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1688 **Author:** [@cnfw](https://github.com/cnfw) **Created:** 9/27/2019 **Status:** ✅ Merged **Merged:** 4/9/2020 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `feature/#1598` --- ### 📝 Commits (1) - [`4ad4dfa`](https://github.com/BookStackApp/BookStack/commit/4ad4dfa55ae75e3e4ebd0537a44c5d0c758636cc) Show bookshelves that a book belongs to on a book view ### 📊 Changes **5 files changed** (+52 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/Entities/Repos/EntityRepo.php` (+11 -0) 📝 `app/Http/Controllers/BookController.php` (+2 -0) 📝 `resources/lang/en/entities.php` (+1 -0) 📝 `resources/views/books/show.blade.php` (+10 -3) 📝 `tests/Entity/BookShelfTest.php` (+28 -0) </details> ### 📄 Description Closes #1598 I put these underneath actions because there could potentially be many that push the actions off-screen. But you will likely want to change the placement of this if this is a feature you wish to merge 👍 Another part of this PR to look out for is the heading above the list. I went with Bookshelves because I think it should be clear enough from the context (a book) that it is referring to the bookshelves that the book can be found on. Thanks ![image](https://user-images.githubusercontent.com/1470412/65732708-047c2480-e0c3-11e9-8cb7-00df00c00b54.png) ![image](https://user-images.githubusercontent.com/1470412/65732749-31c8d280-e0c3-11e9-9079-02a3c31d93ec.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:18:59 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5865