[PR #1687] [MERGED] Fix Book form (create) returning to the full books list on cancel #5859

New Issue

OVERLORD · 2026-02-05T10:18:53+03:00

OVERLORD commented

2026-02-05 10:18:53 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1687
Author: @cnfw
Created: 9/27/2019
Status: ✅ Merged
Merged: 10/27/2019
Merged by: @ssddanbrown

Base: master ← Head: fix/#1662

📝 Commits (1)

2f94f07 Fix Book form (create) returning to the full books list on cancel

📊 Changes

2 files changed (+36 additions, -1 deletions)

View changed files

📝 resources/views/books/form.blade.php (+10 -1)
📝 tests/Entity/EntityTest.php (+26 -0)

📄 Description

Fixes #1662
Added a small block of logic to determine the correct URL to attribute to the cancel button on a given page create form.
If adding a book from a bookshelf, return to the bookshelf. If editing a book, return to the book. In all other cases, return to the full books list.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1687 **Author:** [@cnfw](https://github.com/cnfw) **Created:** 9/27/2019 **Status:** ✅ Merged **Merged:** 10/27/2019 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `fix/#1662` --- ### 📝 Commits (1) - [`2f94f07`](https://github.com/BookStackApp/BookStack/commit/2f94f078e36cf65fa8c7b1d640c030b415714cdc) Fix Book form (create) returning to the full books list on cancel ### 📊 Changes **2 files changed** (+36 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `resources/views/books/form.blade.php` (+10 -1) 📝 `tests/Entity/EntityTest.php` (+26 -0) </details> ### 📄 Description Fixes #1662 Added a small block of logic to determine the correct URL to attribute to the cancel button on a given page create form. If adding a book from a bookshelf, return to the bookshelf. If editing a book, return to the book. In all other cases, return to the full books list. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:18:53 +03:00

OVERLORD closed this issue

2026-02-05 10:18:53 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5859