[PR #1587] [MERGED] Fix 1575 #5840

Closed
opened 2026-02-05 10:18:27 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1587
Author: @james-geiger
Created: 8/15/2019
Status: Merged
Merged: 10/17/2019
Merged by: @ssddanbrown

Base: masterHead: fix-1575


📝 Commits (2)

  • fccc112 Merge pull request #1 from BookStackApp/master
  • c14611d Fixed inline code overflowing off of page in issue #1575.

📊 Changes

2 files changed (+6 additions, -5 deletions)

View changed files

📝 resources/assets/js/services/code.js (+5 -3)
📝 resources/assets/sass/_text.scss (+1 -2)

📄 Description

This PR addressed the problem in #1575 where inline code will overflow off the page. Added line wrapping in codemirror block. Could refactor this into a setting or remove if it doesn't fit into the overall design.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1587 **Author:** [@james-geiger](https://github.com/james-geiger) **Created:** 8/15/2019 **Status:** ✅ Merged **Merged:** 10/17/2019 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `fix-1575` --- ### 📝 Commits (2) - [`fccc112`](https://github.com/BookStackApp/BookStack/commit/fccc112cc104ea9d53f33eb64612095e17f999a7) Merge pull request #1 from BookStackApp/master - [`c14611d`](https://github.com/BookStackApp/BookStack/commit/c14611d14bfd87148fbd96c9e33ed171b01dbd6a) Fixed inline code overflowing off of page in issue #1575. ### 📊 Changes **2 files changed** (+6 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/services/code.js` (+5 -3) 📝 `resources/assets/sass/_text.scss` (+1 -2) </details> ### 📄 Description This PR addressed the problem in #1575 where inline code will overflow off the page. Added line wrapping in codemirror block. Could refactor this into a setting or remove if it doesn't fit into the overall design. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:18:27 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5840