[PR #1509] [CLOSED] Add support for GCS storage #5828

Closed
opened 2026-02-05 10:18:11 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1509
Author: @simonswine
Created: 6/25/2019
Status: Closed

Base: masterHead: add-gcs-storage


📝 Commits (1)

  • dd083a4 Add support for GCS storage

📊 Changes

4 files changed (+30 additions, -26 deletions)

View changed files

📝 .env.example.complete (+10 -0)
📝 app/Uploads/ImageService.php (+9 -26)
📝 config/app.php (+3 -0)
📝 config/filesystems.php (+8 -0)

📄 Description

This seems to work well for us. Not too sure not touched PHP code in years, but more than happy to invest some more time into it.

I think we should use the URL abstraction of laravel-filesystem rather than building it in our code base (getPublicUrl). This would make it easier to support signed temporary URLs as a next step


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1509 **Author:** [@simonswine](https://github.com/simonswine) **Created:** 6/25/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `add-gcs-storage` --- ### 📝 Commits (1) - [`dd083a4`](https://github.com/BookStackApp/BookStack/commit/dd083a414d6d172ade9f5a88548a91b8b29f1484) Add support for GCS storage ### 📊 Changes **4 files changed** (+30 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `.env.example.complete` (+10 -0) 📝 `app/Uploads/ImageService.php` (+9 -26) 📝 `config/app.php` (+3 -0) 📝 `config/filesystems.php` (+8 -0) </details> ### 📄 Description This seems to work well for us. Not too sure not touched PHP code in years, but more than happy to invest some more time into it. I think we should use the URL abstraction of laravel-filesystem rather than building it in our code base (getPublicUrl). This would make it easier to support signed temporary URLs as a next step --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:18:11 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5828