[PR #1505] [MERGED] Hide permissions table unless custom permissions are enabled #5827

Closed
opened 2026-02-05 10:18:11 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1505
Author: @timoschwarzer
Created: 6/23/2019
Status: Merged
Merged: 6/25/2019
Merged by: @ssddanbrown

Base: masterHead: hide-permissions-table-unless-enabled


📝 Commits (1)

  • 6504a6f Hide permissions table unless custom permissions are enabled

📊 Changes

3 files changed (+24 additions, -2 deletions)

View changed files

resources/assets/js/components/entity-permissions-editor.js (+20 -0)
📝 resources/assets/js/components/index.js (+2 -0)
📝 resources/views/form/entity-permissions.blade.php (+2 -2)

📄 Description

I just spent too much time figuring out why my custom permissions were not working. Turned out I didn't enable them.

This PR hides the permissions table unless you enable custom permissions. That should save some time and frustration for users who apparently cannot read (like me 😄).

hide-permissions-table


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1505 **Author:** [@timoschwarzer](https://github.com/timoschwarzer) **Created:** 6/23/2019 **Status:** ✅ Merged **Merged:** 6/25/2019 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `hide-permissions-table-unless-enabled` --- ### 📝 Commits (1) - [`6504a6f`](https://github.com/BookStackApp/BookStack/commit/6504a6f5996ce8fb88d1a4151d0ec83300869aa9) Hide permissions table unless custom permissions are enabled ### 📊 Changes **3 files changed** (+24 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `resources/assets/js/components/entity-permissions-editor.js` (+20 -0) 📝 `resources/assets/js/components/index.js` (+2 -0) 📝 `resources/views/form/entity-permissions.blade.php` (+2 -2) </details> ### 📄 Description I just spent too much time figuring out why my custom permissions were not working. Turned out I didn't enable them. This PR hides the permissions table unless you enable custom permissions. That should save some time and frustration for users who apparently cannot read (like me :smile:). ![hide-permissions-table](https://user-images.githubusercontent.com/8849554/59976365-ad4a4d80-95c3-11e9-9289-f18e1fd7cf0e.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:18:11 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5827