[PR #1497] [CLOSED] Added i18n support for default data #5824

New Issue

OVERLORD · 2026-02-05T10:18:03+03:00

OVERLORD commented

2026-02-05 10:18:03 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1497
Author: @kostasdizas
Created: 6/18/2019
Status: ❌ Closed

Base: master ← Head: i18n-migrations

📝 Commits (1)

b069d6e Added i18n support for default data

📊 Changes

10 files changed (+120 additions, -57 deletions)

View changed files

📝 database/migrations/2014_10_12_000000_create_users_table.php (+1 -1)
📝 database/migrations/2015_08_29_105422_add_roles_and_permissions.php (+14 -14)
📝 database/migrations/2016_02_27_120329_update_permissions_and_roles.php (+17 -17)
📝 database/migrations/2016_04_09_100730_add_view_permissions_to_roles.php (+4 -4)
📝 database/migrations/2016_04_20_192649_create_joint_permissions_table.php (+5 -5)
📝 database/migrations/2016_09_29_101449_remove_hidden_roles.php (+2 -2)
📝 database/migrations/2016_10_09_142037_create_attachments_table.php (+4 -4)
📝 database/migrations/2017_08_01_130541_create_comments_table.php (+7 -7)
📝 database/migrations/2018_08_04_115700_create_bookshelves_table.php (+4 -3)
➕ resources/lang/en/migrations.php (+62 -0)

📄 Description

Default data loaded as part of the initial setup and/or upgrades can now be translated.

This is meant to be a draft commit, most new strings are not very i18n friendly yet.

I'd appreciate some feedback on how this was done. One of the main issues that came up, is that the translation file introduced contains strings that are no longer valid, which might be an unnecessary burden for translators.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1497 **Author:** [@kostasdizas](https://github.com/kostasdizas) **Created:** 6/18/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `i18n-migrations` --- ### 📝 Commits (1) - [`b069d6e`](https://github.com/BookStackApp/BookStack/commit/b069d6e652b0c8d16a94d8a5d461dc2c24a1e647) Added i18n support for default data ### 📊 Changes **10 files changed** (+120 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `database/migrations/2014_10_12_000000_create_users_table.php` (+1 -1) 📝 `database/migrations/2015_08_29_105422_add_roles_and_permissions.php` (+14 -14) 📝 `database/migrations/2016_02_27_120329_update_permissions_and_roles.php` (+17 -17) 📝 `database/migrations/2016_04_09_100730_add_view_permissions_to_roles.php` (+4 -4) 📝 `database/migrations/2016_04_20_192649_create_joint_permissions_table.php` (+5 -5) 📝 `database/migrations/2016_09_29_101449_remove_hidden_roles.php` (+2 -2) 📝 `database/migrations/2016_10_09_142037_create_attachments_table.php` (+4 -4) 📝 `database/migrations/2017_08_01_130541_create_comments_table.php` (+7 -7) 📝 `database/migrations/2018_08_04_115700_create_bookshelves_table.php` (+4 -3) ➕ `resources/lang/en/migrations.php` (+62 -0) </details> ### 📄 Description Default data loaded as part of the initial setup and/or upgrades can now be translated. This is meant to be a draft commit, most new strings are not very i18n friendly yet. I'd appreciate some feedback on how this was done. One of the main issues that came up, is that the translation file introduced contains strings that are no longer valid, which might be an unnecessary burden for translators. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:18:03 +03:00

OVERLORD closed this issue

2026-02-05 10:18:07 +03:00

OVERLORD referenced this issue

2026-02-05 10:35:52 +03:00

[PR #5824] [CLOSED] Improve database skip detection in tests #6572

Sign in to join this conversation.