[PR #1410] [MERGED] Image management rewrite #5810

New Issue

OVERLORD · 2026-02-05T10:17:42+03:00

OVERLORD commented

2026-02-05 10:17:42 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1410
Author: @ssddanbrown
Created: 4/27/2019
Status: ✅ Merged
Merged: 5/4/2019
Merged by: @ssddanbrown

Base: master ← Head: image_management_rewrite

📝 Commits (6)

6428f32 Prevented invalid form inputs having incorrect padding
aeb1fc4 Started rewriting back-end image managment
a87ae16 Started extraction of image controller to separate controllers
cb832a2 Started diversion to not using image manager for cover/system/user
79f6dc0 Change image-selector to not use manager
8c19032 Updated existing image tests to reflect changes

📊 Changes

36 files changed (+963 additions, -577 deletions)

View changed files

📝 app/Auth/Permissions/PermissionService.php (+8 -3)
📝 app/Auth/User.php (+1 -1)
📝 app/Auth/UserRepo.php (+1 -1)
📝 app/Entities/Repos/EntityRepo.php (+1 -1)
📝 app/Http/Controllers/BookController.php (+49 -5)
📝 app/Http/Controllers/BookshelfController.php (+81 -41)
➖ app/Http/Controllers/ImageController.php (+0 -246)
➕ app/Http/Controllers/Images/DrawioImageController.php (+89 -0)
➕ app/Http/Controllers/Images/GalleryImageController.php (+65 -0)
➕ app/Http/Controllers/Images/ImageController.php (+115 -0)
📝 app/Http/Controllers/SettingController.php (+32 -1)
📝 app/Http/Controllers/UserController.php (+29 -18)
📝 app/Uploads/Image.php (+11 -0)
📝 app/Uploads/ImageRepo.php (+95 -56)
📝 app/Uploads/ImageService.php (+43 -12)
📝 resources/assets/js/components/image-picker.js (+26 -30)
📝 resources/assets/js/components/markdown-editor.js (+1 -3)
📝 resources/assets/js/components/wysiwyg-editor.js (+18 -21)
📝 resources/assets/js/services/drawio.js (+20 -1)
📝 resources/assets/js/vues/image-manager.js (+52 -48)

...and 16 more files

📄 Description

Not really happy with the current image management in BookStack.
This is a planned revamp of how images are handled to make things more streamlined and secure.

The plan is to remove the use of an image manager for user, system & cover images so you just select an image directly for these items.

Want to get this done for the redesign release.

--

Will address #1128 and #1307.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1410 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 4/27/2019 **Status:** ✅ Merged **Merged:** 5/4/2019 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `image_management_rewrite` --- ### 📝 Commits (6) - [`6428f32`](https://github.com/BookStackApp/BookStack/commit/6428f324839eaea1c897dc1b8e1fc9af5e5fecf3) Prevented invalid form inputs having incorrect padding - [`aeb1fc4`](https://github.com/BookStackApp/BookStack/commit/aeb1fc4d49b0641bd585a8b62bb553979e101bb2) Started rewriting back-end image managment - [`a87ae16`](https://github.com/BookStackApp/BookStack/commit/a87ae1601061322e7e7b2dc11658f56467761787) Started extraction of image controller to separate controllers - [`cb832a2`](https://github.com/BookStackApp/BookStack/commit/cb832a2c10984b91bb7dbf4df7874bbb2e7dcbef) Started diversion to not using image manager for cover/system/user - [`79f6dc0`](https://github.com/BookStackApp/BookStack/commit/79f6dc00a366fbb318ac70db7ec1128615482655) Change image-selector to not use manager - [`8c19032`](https://github.com/BookStackApp/BookStack/commit/8c190324ac5f8debdb5ee643a38a36667d977bfd) Updated existing image tests to reflect changes ### 📊 Changes **36 files changed** (+963 additions, -577 deletions) <details> <summary>View changed files</summary> 📝 `app/Auth/Permissions/PermissionService.php` (+8 -3) 📝 `app/Auth/User.php` (+1 -1) 📝 `app/Auth/UserRepo.php` (+1 -1) 📝 `app/Entities/Repos/EntityRepo.php` (+1 -1) 📝 `app/Http/Controllers/BookController.php` (+49 -5) 📝 `app/Http/Controllers/BookshelfController.php` (+81 -41) ➖ `app/Http/Controllers/ImageController.php` (+0 -246) ➕ `app/Http/Controllers/Images/DrawioImageController.php` (+89 -0) ➕ `app/Http/Controllers/Images/GalleryImageController.php` (+65 -0) ➕ `app/Http/Controllers/Images/ImageController.php` (+115 -0) 📝 `app/Http/Controllers/SettingController.php` (+32 -1) 📝 `app/Http/Controllers/UserController.php` (+29 -18) 📝 `app/Uploads/Image.php` (+11 -0) 📝 `app/Uploads/ImageRepo.php` (+95 -56) 📝 `app/Uploads/ImageService.php` (+43 -12) 📝 `resources/assets/js/components/image-picker.js` (+26 -30) 📝 `resources/assets/js/components/markdown-editor.js` (+1 -3) 📝 `resources/assets/js/components/wysiwyg-editor.js` (+18 -21) 📝 `resources/assets/js/services/drawio.js` (+20 -1) 📝 `resources/assets/js/vues/image-manager.js` (+52 -48) _...and 16 more files_ </details> ### 📄 Description Not really happy with the current image management in BookStack. This is a planned revamp of how images are handled to make things more streamlined and secure. The plan is to remove the use of an image manager for user, system & cover images so you just select an image directly for these items. Want to get this done for the redesign release. -- Will address #1128 and #1307. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:17:42 +03:00

OVERLORD closed this issue

2026-02-05 10:17:46 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5810