[PR #1395] [MERGED] Add sign up link to login screen and fix registration form validation #5807

New Issue

OVERLORD · 2026-02-05T10:17:40+03:00

OVERLORD commented

2026-02-05 10:17:40 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1395
Author: @cnfw
Created: 4/16/2019
Status: ✅ Merged
Merged: 4/21/2019
Merged by: @ssddanbrown

Base: master ← Head: fix/registraion-form-validation

📝 Commits (1)

c8cf673 Add min length validation on name on register form & add sign up link

📊 Changes

5 files changed (+35 additions, -5 deletions)

View changed files

📝 app/Http/Controllers/Auth/RegisterController.php (+1 -1)
📝 resources/views/auth/forms/login/standard.blade.php (+7 -2)
📝 resources/views/auth/login.blade.php (+1 -1)
📝 resources/views/common/header.blade.php (+1 -1)
📝 tests/Auth/AuthTest.php (+25 -0)

📄 Description

I think people expect to find a sign up link close to the login form, so added one next to forgot password if registration is enabled. Also fixed #1239 while I was there.

Hope this helps.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1395 **Author:** [@cnfw](https://github.com/cnfw) **Created:** 4/16/2019 **Status:** ✅ Merged **Merged:** 4/21/2019 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `fix/registraion-form-validation` --- ### 📝 Commits (1) - [`c8cf673`](https://github.com/BookStackApp/BookStack/commit/c8cf6731e2be8f8a9bf7aa15b864690e71507548) Add min length validation on name on register form & add sign up link ### 📊 Changes **5 files changed** (+35 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/Auth/RegisterController.php` (+1 -1) 📝 `resources/views/auth/forms/login/standard.blade.php` (+7 -2) 📝 `resources/views/auth/login.blade.php` (+1 -1) 📝 `resources/views/common/header.blade.php` (+1 -1) 📝 `tests/Auth/AuthTest.php` (+25 -0) </details> ### 📄 Description I think people expect to find a sign up link close to the login form, so added one next to forgot password if registration is enabled. Also fixed #1239 while I was there. <img width="506" alt="image" src="https://user-images.githubusercontent.com/1470412/56205636-426c1b80-6042-11e9-90c8-5afff3ad9918.png"> <img width="483" alt="image" src="https://user-images.githubusercontent.com/1470412/56205664-531c9180-6042-11e9-9eb1-85f290d33b2a.png"> Hope this helps. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:17:40 +03:00

OVERLORD closed this issue

2026-02-05 10:17:43 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5807