[PR #1314] [MERGED] Update Dutch password_hint translation to correspond with validation #5799

Closed
opened 2026-02-05 10:17:24 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1314
Author: @maantje
Created: 3/6/2019
Status: Merged
Merged: 3/8/2019
Merged by: @ssddanbrown

Base: masterHead: patch-2


📝 Commits (1)

  • 6f71022 Update Dutch password_hint translation to correspond with validation rule

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 resources/lang/nl/auth.php (+2 -2)

📄 Description

At the moment the Dutch translation says Minimaal 5 tekens which means your password should be at least 5 characters long. But a 5 character long password is not allowed by the validator.

I think this was a translation error from the English one where it says Must be over 5 characters. To make the Dutch translation correct the Dutch translation should be changed to Minimaal 6 tekens.

/**
 * Get a validator for an incoming registration request.
 *
 * @param  array $data
 * @return \Illuminate\Contracts\Validation\Validator
 */
protected function validator(array $data)
{
    return Validator::make($data, [
        'name' => 'required|max:255',
        'email' => 'required|email|max:255|unique:users',
        'password' => 'required|min:6',
    ]);
}

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1314 **Author:** [@maantje](https://github.com/maantje) **Created:** 3/6/2019 **Status:** ✅ Merged **Merged:** 3/8/2019 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`6f71022`](https://github.com/BookStackApp/BookStack/commit/6f710225b51f10ea474aa2b2f62573c5d9251209) Update Dutch password_hint translation to correspond with validation rule ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `resources/lang/nl/auth.php` (+2 -2) </details> ### 📄 Description At the moment the Dutch translation says ```Minimaal 5 tekens``` which means your password should be at least 5 characters long. But a 5 character long password is not allowed by the validator. I think this was a translation error from the English one where it says ```Must be over 5 characters```. To make the Dutch translation correct the Dutch translation should be changed to ```Minimaal 6 tekens```. ``` /** * Get a validator for an incoming registration request. * * @param array $data * @return \Illuminate\Contracts\Validation\Validator */ protected function validator(array $data) { return Validator::make($data, [ 'name' => 'required|max:255', 'email' => 'required|email|max:255|unique:users', 'password' => 'required|min:6', ]); } ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:17:24 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5799