[PR #1275] [CLOSED] Dynamic Links and Editor Integration #5794

New Issue

OVERLORD · 2026-02-05T10:17:16+03:00

OVERLORD commented

2026-02-05 10:17:16 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1275
Author: @Xiphoseer
Created: 2/13/2019
Status: ❌ Closed

Base: master ← Head: dynamic-links-editors

📝 Commits (7)

46cb850 Dynamically Render Page Links
0ac3b15 Inclusion of Chapters and Books in Dynamic Linking
25f4ea7 Write blank href on bracket count mismatch
32f3441 Rewrite dynamic links to use {{entity@id}}
a8651cd Switch to URI 'bookstackapp:'
d60d67a Update editors to use dynamic links
031cc39 Add bookstack:ref:

📊 Changes

4 files changed (+122 additions, -4 deletions)

View changed files

📝 app/Entities/Repos/EntityRepo.php (+71 -0)
📝 resources/assets/js/components/entity-selector.js (+1 -1)
📝 resources/assets/js/components/markdown-editor.js (+49 -2)
📝 resources/assets/js/components/wysiwyg-editor.js (+1 -1)

📄 Description

This PR is to provide an implementation for the seemingly abandoned #737. It also includes some changes to the Markdown and WYSIWYG editor, to use the new syntax by default.

I'll provide more details later, but I chose a custom URI as the most appropriate solution to implement this feature, as it works nicely alongside other link-schemes, does not produce URL-encoded characters, wherever it is used. I'll also submit a pull-request for another branch, which does not touch the editors at all, making this feature entirely optional for the user.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1275 **Author:** [@Xiphoseer](https://github.com/Xiphoseer) **Created:** 2/13/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dynamic-links-editors` --- ### 📝 Commits (7) - [`46cb850`](https://github.com/BookStackApp/BookStack/commit/46cb850c1e98384f434a11594d7535c44635aba6) Dynamically Render Page Links - [`0ac3b15`](https://github.com/BookStackApp/BookStack/commit/0ac3b1557d91c40136fe8de90d10112a90070f95) Inclusion of Chapters and Books in Dynamic Linking - [`25f4ea7`](https://github.com/BookStackApp/BookStack/commit/25f4ea71254f109937e2b5f0e4f8985bf98aeaba) Write blank href on bracket count mismatch - [`32f3441`](https://github.com/BookStackApp/BookStack/commit/32f344199fa93ba4a1c52e1e022ae59256038221) Rewrite dynamic links to use {{entity@id}} - [`a8651cd`](https://github.com/BookStackApp/BookStack/commit/a8651cd0aa3f32158afc3c04abf8a11e3d1b136b) Switch to URI 'bookstackapp:' - [`d60d67a`](https://github.com/BookStackApp/BookStack/commit/d60d67affca5294266558f3660acd5e2d23066fa) Update editors to use dynamic links - [`031cc39`](https://github.com/BookStackApp/BookStack/commit/031cc395c5d6c19eb9a0c49bb941335f6a115460) Add bookstack:ref: ### 📊 Changes **4 files changed** (+122 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `app/Entities/Repos/EntityRepo.php` (+71 -0) 📝 `resources/assets/js/components/entity-selector.js` (+1 -1) 📝 `resources/assets/js/components/markdown-editor.js` (+49 -2) 📝 `resources/assets/js/components/wysiwyg-editor.js` (+1 -1) </details> ### 📄 Description This PR is to provide an implementation for the seemingly abandoned #737. It also includes some changes to the Markdown and WYSIWYG editor, to use the new syntax by default. I'll provide more details later, but I chose a custom URI as the most appropriate solution to implement this feature, as it works nicely alongside other link-schemes, does not produce URL-encoded characters, wherever it is used. I'll also submit a pull-request for another branch, which does not touch the editors at all, making this feature entirely optional for the user. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:17:16 +03:00

OVERLORD closed this issue

2026-02-05 10:17:18 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5794