[PR #1278] [CLOSED] Bugfix: ldap_connect() ignores argument when given an URI #5793

New Issue

OVERLORD · 2026-02-05T10:17:15+03:00

OVERLORD commented

2026-02-05 10:17:15 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1278
Author: @Fahrplan
Created: 2/14/2019
Status: ❌ Closed

Base: master ← Head: patch-1

📝 Commits (1)

0fc51b5 Bugfix: ldap_connect() ignores argument when given an URI

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 app/Auth/Access/Ldap.php (+5 -1)

📄 Description

ldap_connect() ignores the port argument, if $hostname is in the Form of an ldap-URI (like ldaps://....), therefore the $port must be added to the first argument, if an URI is present, otherwise it allways tries to use Port 636.

This is a quick fix, which probably needs some further adjustment.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1278 **Author:** [@Fahrplan](https://github.com/Fahrplan) **Created:** 2/14/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`0fc51b5`](https://github.com/BookStackApp/BookStack/commit/0fc51b5ffe97cf3a185eb88039c8ffcdc9f1a890) Bugfix: ldap_connect() ignores argument when given an URI ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Auth/Access/Ldap.php` (+5 -1) </details> ### 📄 Description ldap_connect() ignores the port argument, if $hostname is in the Form of an ldap-URI (like ldaps://....), therefore the $port must be added to the first argument, if an URI is present, otherwise it allways tries to use Port 636. This is a quick fix, which probably needs some further adjustment. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:17:15 +03:00

OVERLORD closed this issue

2026-02-05 10:17:18 +03:00

OVERLORD referenced this issue

2026-02-05 10:35:47 +03:00

[PR #5793] [MERGED] Permissions: Use of enum references and RolePermission cleanup #6569

Sign in to join this conversation.