[PR #1202] [MERGED] Copy function for view only pages #5787

Closed
opened 2026-02-05 10:17:07 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1202
Author: @mark-james
Created: 12/31/2018
Status: Merged
Merged: 3/9/2019
Merged by: @ssddanbrown

Base: masterHead: Copy-For-View-Only


📝 Commits (3)

  • 0830521 Merge pull request #1 from BookStackApp/master
  • 99c6d70 Initial updates to allow for page copy when the user can read the page but can't update it.
  • 19770d2 Use joint_permissions to determine is a user has an available page or chapter to copy.

📊 Changes

4 files changed (+44 additions, -4 deletions)

View changed files

📝 app/Auth/Permissions/PermissionService.php (+27 -0)
📝 app/Http/Controllers/PageController.php (+2 -2)
📝 app/helpers.php (+11 -0)
📝 resources/views/pages/show.blade.php (+4 -2)

📄 Description

Hi @ssddanbrown ,
I'd like to open a pull request to handle the ability to copy a read only page as discussed in #1199

This request is not yet complete.

Currently if a user has at least one of 'create page own' or 'create page all' then the option to copy the page is available. I deemed this as a prerequisite of any copy functionality.

There are (at least) two outstanding issues.
A user doesn't select a destination and pushes the copy button. And a variation when a user attempts to copy a page but does not have an existing destination available to copy it too.

How do you want to handle this?

What else do I need to consider?


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1202 **Author:** [@mark-james](https://github.com/mark-james) **Created:** 12/31/2018 **Status:** ✅ Merged **Merged:** 3/9/2019 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `Copy-For-View-Only` --- ### 📝 Commits (3) - [`0830521`](https://github.com/BookStackApp/BookStack/commit/0830521e60d782963e4e781b92c04eb9627abebe) Merge pull request #1 from BookStackApp/master - [`99c6d70`](https://github.com/BookStackApp/BookStack/commit/99c6d70c5160e3c050218eec44180176718a36d8) Initial updates to allow for page copy when the user can read the page but can't update it. - [`19770d2`](https://github.com/BookStackApp/BookStack/commit/19770d27924647314e0b54fda10dde4704980926) Use joint_permissions to determine is a user has an available page or chapter to copy. ### 📊 Changes **4 files changed** (+44 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `app/Auth/Permissions/PermissionService.php` (+27 -0) 📝 `app/Http/Controllers/PageController.php` (+2 -2) 📝 `app/helpers.php` (+11 -0) 📝 `resources/views/pages/show.blade.php` (+4 -2) </details> ### 📄 Description Hi @ssddanbrown , I'd like to open a pull request to handle the ability to copy a read only page as discussed in #1199 This request is not yet complete. Currently if a user has at least one of 'create page own' or 'create page all' then the option to copy the page is available. I deemed this as a prerequisite of any copy functionality. There are (at least) two outstanding issues. A user doesn't select a destination and pushes the copy button. And a variation when a user attempts to copy a page but does not have an existing destination available to copy it too. How do you want to handle this? What else do I need to consider? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:17:07 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5787