[PR #1143] [MERGED] Fixes image deletion failing in subdirectory. #5778

New Issue

OVERLORD · 2026-02-05T10:16:53+03:00

OVERLORD commented

2026-02-05 10:16:53 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1143
Author: @Abijeet
Created: 11/24/2018
Status: ✅ Merged
Merged: 11/28/2018
Merged by: @ssddanbrown

Base: master ← Head: fix-image-delete

📝 Commits (1)

eac82c4 Fixes image deletion failing in subdirectory.

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 resources/assets/js/vues/image-manager.js (+2 -2)

📄 Description

Fixes #1092

I was unable to test it on a sub-directory, since while setting up was getting an issue stating -

[Sun Nov 25 00:14:25.175814 2018] [core:error] [pid 30398] [client ::1:50186] AH00124: Request exceeded the limit of 10 internal redirects due to probable configuration error. Use 'LimitInternalRecursion' to increase the limit if necessary. Use 'LogLevel debug' to get a backtrace.

But I'm fairly certain that this will fix the issue. Tested on the PHP localhost server.

Signed-off-by: Abijeet abijeetpatro@gmail.com

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1143 **Author:** [@Abijeet](https://github.com/Abijeet) **Created:** 11/24/2018 **Status:** ✅ Merged **Merged:** 11/28/2018 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `fix-image-delete` --- ### 📝 Commits (1) - [`eac82c4`](https://github.com/BookStackApp/BookStack/commit/eac82c47a5170bf9fde12ce94fa45ad232e7265d) Fixes image deletion failing in subdirectory. ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/vues/image-manager.js` (+2 -2) </details> ### 📄 Description Fixes #1092 I was unable to test it on a sub-directory, since while setting up was getting an issue stating - ``` [Sun Nov 25 00:14:25.175814 2018] [core:error] [pid 30398] [client ::1:50186] AH00124: Request exceeded the limit of 10 internal redirects due to probable configuration error. Use 'LimitInternalRecursion' to increase the limit if necessary. Use 'LogLevel debug' to get a backtrace. ``` But I'm fairly certain that this will fix the issue. Tested on the PHP localhost server. Signed-off-by: Abijeet <abijeetpatro@gmail.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:16:53 +03:00

OVERLORD closed this issue

2026-02-05 10:16:57 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5778