[PR #1008] [MERGED] #784 - Adds ability to remove particular revision. #5753

New Issue

OVERLORD · 2026-02-05T10:16:11+03:00

OVERLORD commented

2026-02-05 10:16:11 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/1008
Author: @Abijeet
Created: 9/15/2018
Status: ✅ Merged
Merged: 9/16/2018
Merged by: @Abijeet

Base: master ← Head: revision-deletion

📝 Commits (7)

714c7bb Adds code to delete the revision.
f0add69 Adding languages for the revision deletion.
25da4d9 Added a success message on deletion of revision.
54ca448 Adds tests and few fixes.
81d3bdc Removes the BadRequestException class added earlier.
0c8b6b7 Final tweaks after code review and fixing failing test cases.
08b9676 Changes as per code review, and fixes failing test cases.

📊 Changes

23 files changed (+207 additions, -6 deletions)

View changed files

📝 app/Http/Controllers/PageController.php (+34 -0)
📝 app/Page.php (+9 -0)
📝 resources/assets/sass/_lists.scss (+5 -1)
📝 resources/assets/sass/_tables.scss (+3 -0)
📝 resources/lang/de/entities.php (+7 -0)
📝 resources/lang/en/entities.php (+7 -0)
📝 resources/lang/es/entities.php (+7 -0)
📝 resources/lang/es_AR/entities.php (+7 -0)
📝 resources/lang/fr/entities.php (+7 -0)
📝 resources/lang/it/entities.php (+7 -0)
📝 resources/lang/ja/entities.php (+7 -0)
📝 resources/lang/nl/entities.php (+7 -0)
📝 resources/lang/pl/entities.php (+7 -0)
📝 resources/lang/pt_BR/entities.php (+7 -0)
📝 resources/lang/ru/entities.php (+7 -0)
📝 resources/lang/sk/entities.php (+7 -0)
📝 resources/lang/sv/entities.php (+7 -0)
📝 resources/lang/zh_CN/entities.php (+7 -0)
📝 resources/lang/zh_TW/entities.php (+7 -0)
📝 resources/views/pages/revisions.blade.php (+16 -1)

...and 3 more files

📄 Description

Hey @ssddanbrown ,

Been a little busy with my professional life and haven't had a chance to work on BookStack. Finally got some time this weekend.

Here's what's been done,

Added a drop-down for deletion confirmation on the revision page.
Wrote code to delete the revision
Added test cases.

Note that I'm not reducing the revision_count column in the pages table. I think the current revision number should not be changed.

Screenshot

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/1008 **Author:** [@Abijeet](https://github.com/Abijeet) **Created:** 9/15/2018 **Status:** ✅ Merged **Merged:** 9/16/2018 **Merged by:** [@Abijeet](https://github.com/Abijeet) **Base:** `master` ← **Head:** `revision-deletion` --- ### 📝 Commits (7) - [`714c7bb`](https://github.com/BookStackApp/BookStack/commit/714c7bbd3a16ab905ac41f7a20831d701532641f) Adds code to delete the revision. - [`f0add69`](https://github.com/BookStackApp/BookStack/commit/f0add69b61ca1aef31e028ce63898c02e825e9d7) Adding languages for the revision deletion. - [`25da4d9`](https://github.com/BookStackApp/BookStack/commit/25da4d9a8bb113b1f28fa54d9b8ea5e7eede1681) Added a success message on deletion of revision. - [`54ca448`](https://github.com/BookStackApp/BookStack/commit/54ca4487faf46b52fe5f0457cd194c0492ce3e47) Adds tests and few fixes. - [`81d3bdc`](https://github.com/BookStackApp/BookStack/commit/81d3bdc168cdd1b55edabf0dc17a8534903aa585) Removes the BadRequestException class added earlier. - [`0c8b6b7`](https://github.com/BookStackApp/BookStack/commit/0c8b6b7324189c3028981d348587fa125d8c8438) Final tweaks after code review and fixing failing test cases. - [`08b9676`](https://github.com/BookStackApp/BookStack/commit/08b967607f14c48d7a1b9f5bf43b872b2494a3f0) Changes as per code review, and fixes failing test cases. ### 📊 Changes **23 files changed** (+207 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/PageController.php` (+34 -0) 📝 `app/Page.php` (+9 -0) 📝 `resources/assets/sass/_lists.scss` (+5 -1) 📝 `resources/assets/sass/_tables.scss` (+3 -0) 📝 `resources/lang/de/entities.php` (+7 -0) 📝 `resources/lang/en/entities.php` (+7 -0) 📝 `resources/lang/es/entities.php` (+7 -0) 📝 `resources/lang/es_AR/entities.php` (+7 -0) 📝 `resources/lang/fr/entities.php` (+7 -0) 📝 `resources/lang/it/entities.php` (+7 -0) 📝 `resources/lang/ja/entities.php` (+7 -0) 📝 `resources/lang/nl/entities.php` (+7 -0) 📝 `resources/lang/pl/entities.php` (+7 -0) 📝 `resources/lang/pt_BR/entities.php` (+7 -0) 📝 `resources/lang/ru/entities.php` (+7 -0) 📝 `resources/lang/sk/entities.php` (+7 -0) 📝 `resources/lang/sv/entities.php` (+7 -0) 📝 `resources/lang/zh_CN/entities.php` (+7 -0) 📝 `resources/lang/zh_TW/entities.php` (+7 -0) 📝 `resources/views/pages/revisions.blade.php` (+16 -1) _...and 3 more files_ </details> ### 📄 Description Hey @ssddanbrown , Been a little busy with my professional life and haven't had a chance to work on BookStack. Finally got some time this weekend. Here's what's been done, 1. Added a drop-down for deletion confirmation on the revision page. 2. Wrote code to delete the revision 3. Added test cases. Note that I'm not reducing the `revision_count` column in the pages table. I think the current revision number should not be changed. # Screenshot ![bookstack-revision-ddl-2](https://user-images.githubusercontent.com/1685517/45588078-91c35f80-b92c-11e8-9896-3f189c1931ca.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:16:11 +03:00

OVERLORD closed this issue

2026-02-05 10:16:13 +03:00

OVERLORD referenced this issue

2026-02-05 10:35:33 +03:00

[PR #5753] [MERGED] A11y: Improved menu tagging #6558

Sign in to join this conversation.