[PR #966] [MERGED] implement social auto registration feature #5750

Closed
opened 2026-02-05 10:16:04 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/966
Author: @ibrahimennafaa
Created: 8/17/2018
Status: Merged
Merged: 9/21/2018
Merged by: @ssddanbrown

Base: masterHead: feature/autoregistration_social_login


📝 Commits (4)

  • fe6dfce implement social auto registration feature
  • b224a2c attempt to fix unit test error for admin creation
  • 572e75b Update UserRepo.php
  • d2f5313 add missing @param in method comment

📊 Changes

4 files changed (+50 additions, -6 deletions)

View changed files

📝 app/Repos/UserRepo.php (+8 -5)
📝 app/Services/SocialAuthService.php (+34 -0)
📝 resources/lang/en/settings.php (+3 -1)
📝 resources/views/settings/index.blade.php (+5 -0)

📄 Description

Related to #574

I added a setting to allow auto silent registration of user when social auth is used.

Few things to be aware of:

  • enabling this setting would disable email verification for social auth but it's described under the setting + I think email verification for social auth is useless.
  • if domain restriction is enabled => the auto social registration process respect it.
    Missing: translation & probably better wording (my english is not perfect)

Missing: check of wording + translations


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/966 **Author:** [@ibrahimennafaa](https://github.com/ibrahimennafaa) **Created:** 8/17/2018 **Status:** ✅ Merged **Merged:** 9/21/2018 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `feature/autoregistration_social_login` --- ### 📝 Commits (4) - [`fe6dfce`](https://github.com/BookStackApp/BookStack/commit/fe6dfcedf9692128c0f394657dbdfac7cc0cf2c9) implement social auto registration feature - [`b224a2c`](https://github.com/BookStackApp/BookStack/commit/b224a2c8a0862ca4d91389bba4d98cfaef3127b8) attempt to fix unit test error for admin creation - [`572e75b`](https://github.com/BookStackApp/BookStack/commit/572e75b7831c67f59a873e455565216441a3f2d8) Update UserRepo.php - [`d2f5313`](https://github.com/BookStackApp/BookStack/commit/d2f5313f92c857c4ff71aea5cdb206662be20f3e) add missing @param in method comment ### 📊 Changes **4 files changed** (+50 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `app/Repos/UserRepo.php` (+8 -5) 📝 `app/Services/SocialAuthService.php` (+34 -0) 📝 `resources/lang/en/settings.php` (+3 -1) 📝 `resources/views/settings/index.blade.php` (+5 -0) </details> ### 📄 Description Related to #574 I added a setting to allow auto silent registration of user when social auth is used. Few things to be aware of: - enabling this setting would disable email verification for social auth but it's described under the setting + I think email verification for social auth is useless. - if domain restriction is enabled => the auto social registration process respect it. Missing: translation & probably better wording (my english is not perfect) Missing: check of wording + translations --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:16:04 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5750