[PR #965] [CLOSED] Feature/autoregistration social login #5743

Closed
opened 2026-02-05 10:15:56 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/965
Author: @ibrahimennafaa
Created: 8/16/2018
Status: Closed

Base: masterHead: feature/autoregistration_social_login


📝 Commits (10+)

  • 6ad21ce Added built assets for release
  • 448ac14 Merge branch 'master' into release
  • d2cacf1 Release update
  • e99507d Merge branch 'master' into release
  • f517ef3 Added new asset structure
  • a91d426 Merge branch 'master' into release
  • f184d76 Added build folder to release
  • 910faab Merge branch 'master' into release
  • 3b3bc0c Updated compiled assets
  • 4fc75be Merge branch 'master' into release

📊 Changes

10 files changed (+6827 additions, -7 deletions)

View changed files

📝 .gitignore (+1 -1)
📝 app/Repos/UserRepo.php (+7 -5)
📝 app/Services/SocialAuthService.php (+34 -0)
public/dist/app.js (+1 -0)
public/dist/export-styles.css (+2497 -0)
public/dist/print-styles.css (+25 -0)
public/dist/styles.css (+4254 -0)
📝 resources/lang/en/settings.php (+2 -0)
📝 resources/views/settings/index.blade.php (+5 -0)
📝 version (+1 -1)

📄 Description

Sorry deleted.

I added a setting to allow auto silent signup of user when social auth is used.

Few things to be aware of:

  • enabling this setting would disable email verification for social auth but it's described under the setting + I think email verification for social auth is useless.
  • if domain restriction is enabled => the auto social registration process respect it.

Missing: translation & probably better wording (my english is not perfect)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/965 **Author:** [@ibrahimennafaa](https://github.com/ibrahimennafaa) **Created:** 8/16/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/autoregistration_social_login` --- ### 📝 Commits (10+) - [`6ad21ce`](https://github.com/BookStackApp/BookStack/commit/6ad21ce885b9e96680387003bd616ba72add5334) Added built assets for release - [`448ac14`](https://github.com/BookStackApp/BookStack/commit/448ac1405b089c8b32070884ee30713d5be8b0e0) Merge branch 'master' into release - [`d2cacf1`](https://github.com/BookStackApp/BookStack/commit/d2cacf1945eb4640607bc3d1c84ee7e1010a3db5) Release update - [`e99507d`](https://github.com/BookStackApp/BookStack/commit/e99507ddcfe6867d8cc8be51e89353c249d3be6e) Merge branch 'master' into release - [`f517ef3`](https://github.com/BookStackApp/BookStack/commit/f517ef361696ed467c77609d10d1dae3be5d4cbd) Added new asset structure - [`a91d426`](https://github.com/BookStackApp/BookStack/commit/a91d42634d3a8eeb804c1818c10fbdce8b0beec7) Merge branch 'master' into release - [`f184d76`](https://github.com/BookStackApp/BookStack/commit/f184d763ad45b6e46d53ccc27e4a2ade856c10bd) Added build folder to release - [`910faab`](https://github.com/BookStackApp/BookStack/commit/910faab88e34d1a0f50d7d422c79a5e9bf64b28b) Merge branch 'master' into release - [`3b3bc0c`](https://github.com/BookStackApp/BookStack/commit/3b3bc0c4bffb6d9e735eca9d99dbcdb88cd104e4) Updated compiled assets - [`4fc75be`](https://github.com/BookStackApp/BookStack/commit/4fc75beed4663abd2ca077cc8aa26f36e9b793c9) Merge branch 'master' into release ### 📊 Changes **10 files changed** (+6827 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -1) 📝 `app/Repos/UserRepo.php` (+7 -5) 📝 `app/Services/SocialAuthService.php` (+34 -0) ➕ `public/dist/app.js` (+1 -0) ➕ `public/dist/export-styles.css` (+2497 -0) ➕ `public/dist/print-styles.css` (+25 -0) ➕ `public/dist/styles.css` (+4254 -0) 📝 `resources/lang/en/settings.php` (+2 -0) 📝 `resources/views/settings/index.blade.php` (+5 -0) 📝 `version` (+1 -1) </details> ### 📄 Description Sorry deleted. I added a setting to allow auto silent signup of user when social auth is used. Few things to be aware of: - enabling this setting would disable email verification for social auth but it's described under the setting + I think email verification for social auth is useless. - if domain restriction is enabled => the auto social registration process respect it. Missing: translation & probably better wording (my english is not perfect) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:15:56 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5743