[PR #837] [MERGED] Drawing/Image Managment Update #5720

New Issue

OVERLORD · 2026-02-05T10:15:11+03:00

OVERLORD commented

2026-02-05 10:15:11 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/837
Author: @ssddanbrown
Created: 5/13/2018
Status: ✅ Merged
Merged: 5/27/2018
Merged by: @ssddanbrown

Base: master ← Head: drawing_revisions

📝 Commits (3)

d5b922a Started work on drawing revisions
13ad003 Drawings now generate revisions, not replace
6cdb943 Started work on revisions in image manager

📊 Changes

29 files changed (+398 additions, -116 deletions)

View changed files

📝 app/Http/Controllers/ImageController.php (+28 -14)
📝 app/Image.php (+23 -2)
➕ app/ImageRevision.php (+26 -0)
📝 app/Repos/ImageRepo.php (+6 -5)
📝 app/Repos/UserRepo.php (+1 -1)
📝 app/Services/ImageService.php (+81 -31)
➕ database/migrations/2018_05_13_090521_create_image_revisions_table.php (+38 -0)
📝 resources/assets/js/components/wysiwyg-editor.js (+21 -4)
📝 resources/assets/js/vues/image-manager.js (+44 -13)
📝 resources/assets/sass/_components.scss (+29 -8)
📝 resources/assets/sass/styles.scss (+1 -0)
📝 resources/lang/de/components.php (+2 -1)
📝 resources/lang/en/components.php (+2 -1)
📝 resources/lang/es/components.php (+2 -1)
📝 resources/lang/es_AR/components.php (+2 -1)
📝 resources/lang/fr/components.php (+2 -1)
📝 resources/lang/it/components.php (+2 -1)
📝 resources/lang/ja/components.php (+2 -1)
📝 resources/lang/nl/components.php (+2 -1)
📝 resources/lang/pl/components.php (+2 -1)

...and 9 more files

📄 Description

Related to #770

This pull request was originally to add image revisions. Due to complexity and custom handling involved in doing that instead drawings now create upon update as this meets the need of the original issue.

To handle old images a new image-cleanup system has been added as both a command and a new maintenance option within settings.

Other general fixes and improvements are included to the image manager.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/837 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 5/13/2018 **Status:** ✅ Merged **Merged:** 5/27/2018 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `drawing_revisions` --- ### 📝 Commits (3) - [`d5b922a`](https://github.com/BookStackApp/BookStack/commit/d5b922aa50236c047904e94ca38b62026af4bb68) Started work on drawing revisions - [`13ad003`](https://github.com/BookStackApp/BookStack/commit/13ad0031d64ebaff08c2f7b8e1ff819958f6fce3) Drawings now generate revisions, not replace - [`6cdb943`](https://github.com/BookStackApp/BookStack/commit/6cdb94391655a459760d8d20dc138b1f0eb2e4c4) Started work on revisions in image manager ### 📊 Changes **29 files changed** (+398 additions, -116 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/ImageController.php` (+28 -14) 📝 `app/Image.php` (+23 -2) ➕ `app/ImageRevision.php` (+26 -0) 📝 `app/Repos/ImageRepo.php` (+6 -5) 📝 `app/Repos/UserRepo.php` (+1 -1) 📝 `app/Services/ImageService.php` (+81 -31) ➕ `database/migrations/2018_05_13_090521_create_image_revisions_table.php` (+38 -0) 📝 `resources/assets/js/components/wysiwyg-editor.js` (+21 -4) 📝 `resources/assets/js/vues/image-manager.js` (+44 -13) 📝 `resources/assets/sass/_components.scss` (+29 -8) 📝 `resources/assets/sass/styles.scss` (+1 -0) 📝 `resources/lang/de/components.php` (+2 -1) 📝 `resources/lang/en/components.php` (+2 -1) 📝 `resources/lang/es/components.php` (+2 -1) 📝 `resources/lang/es_AR/components.php` (+2 -1) 📝 `resources/lang/fr/components.php` (+2 -1) 📝 `resources/lang/it/components.php` (+2 -1) 📝 `resources/lang/ja/components.php` (+2 -1) 📝 `resources/lang/nl/components.php` (+2 -1) 📝 `resources/lang/pl/components.php` (+2 -1) _...and 9 more files_ </details> ### 📄 Description Related to #770 This pull request was originally to add image revisions. Due to complexity and custom handling involved in doing that instead drawings now create upon update as this meets the need of the original issue. To handle old images a new image-cleanup system has been added as both a command and a new `maintenance` option within settings. Other general fixes and improvements are included to the image manager. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:15:11 +03:00

OVERLORD closed this issue

2026-02-05 10:15:14 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5720