[PR #768] [MERGED] Adds the media plugin to TinyMCE to allow insertion of videos. #5711

New Issue

OVERLORD · 2026-02-05T10:14:55+03:00

OVERLORD commented

2026-02-05 10:14:55 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/768
Author: @Abijeet
Created: 3/27/2018
Status: ✅ Merged
Merged: 4/14/2018
Merged by: @ssddanbrown

Base: master ← Head: feature/tinymce-insert-video

📝 Commits (3)

d92efd4 Adds the media plugin to TinyMCE to allow insertion of videos.
93f92e9 Updated the TinyMCE to version 4.7.9.
7238a01 Moved the code to the wysiwyg-editor file.

📊 Changes

60 files changed (+75 additions, -70 deletions)

View changed files

📝 public/libs/tinymce/plugins/advlist/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/anchor/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/autolink/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/autoresize/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/autosave/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/bbcode/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/charmap/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/code/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/codesample/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/colorpicker/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/contextmenu/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/directionality/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/emoticons/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/fullpage/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/fullscreen/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/help/img/logo.png (+0 -0)
📝 public/libs/tinymce/plugins/help/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/hr/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/image/plugin.min.js (+1 -1)
📝 public/libs/tinymce/plugins/imagetools/plugin.min.js (+1 -2)

...and 40 more files

📄 Description

Fixes #266

Signed-off-by: Abijeet abijeetpatro@gmail.com

I've had to add an ugly hacky fix to remove the "Advanced" tab and the "Open" button,
6f280bb488 (diff-4fd06e033e83fb244f4d8c9752a26781R315)

Otherwise this is how the default media dialog looks like with the open button not really doing anything.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/768 **Author:** [@Abijeet](https://github.com/Abijeet) **Created:** 3/27/2018 **Status:** ✅ Merged **Merged:** 4/14/2018 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `feature/tinymce-insert-video` --- ### 📝 Commits (3) - [`d92efd4`](https://github.com/BookStackApp/BookStack/commit/d92efd4edc9ec642c0d5015183c6c56bde3e0fd8) Adds the media plugin to TinyMCE to allow insertion of videos. - [`93f92e9`](https://github.com/BookStackApp/BookStack/commit/93f92e9e1682e062c7fbfa575450cef121407da3) Updated the TinyMCE to version 4.7.9. - [`7238a01`](https://github.com/BookStackApp/BookStack/commit/7238a01f8978b2061766f3f77ea706a38a149f7c) Moved the code to the wysiwyg-editor file. ### 📊 Changes **60 files changed** (+75 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `public/libs/tinymce/plugins/advlist/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/anchor/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/autolink/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/autoresize/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/autosave/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/bbcode/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/charmap/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/code/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/codesample/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/colorpicker/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/contextmenu/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/directionality/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/emoticons/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/fullpage/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/fullscreen/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/help/img/logo.png` (+0 -0) 📝 `public/libs/tinymce/plugins/help/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/hr/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/image/plugin.min.js` (+1 -1) 📝 `public/libs/tinymce/plugins/imagetools/plugin.min.js` (+1 -2) _...and 40 more files_ </details> ### 📄 Description Fixes #266 Signed-off-by: Abijeet <abijeetpatro@gmail.com> ![screenshot-2018-3-28 editing page new page bookstack](https://user-images.githubusercontent.com/1685517/37989854-2f0642a4-3222-11e8-89e3-15156c6b0845.png) I've had to add an ugly hacky fix to remove the "Advanced" tab and the "Open" button, https://github.com/BookStackApp/BookStack/commit/6f280bb4884b2d693d89e84e69b94f274b9747f3#diff-4fd06e033e83fb244f4d8c9752a26781R315 Otherwise this is how the default media dialog looks like with the open button not really doing anything. ![screenshot-2018-3-28 editing page new page bookstack 1](https://user-images.githubusercontent.com/1685517/37990277-6d1f9864-3223-11e8-9587-3b4321bbe244.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:14:55 +03:00

OVERLORD closed this issue

2026-02-05 10:14:57 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5711