[PR #754] [MERGED] Fixes issues with the image uploader #5705

New Issue

OVERLORD · 2026-02-05T10:14:45+03:00

OVERLORD commented

2026-02-05 10:14:45 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/754
Author: @Abijeet
Created: 3/18/2018
Status: ✅ Merged
Merged: 3/24/2018
Merged by: @ssddanbrown

Base: master ← Head: bug/image-upload

📝 Commits (5)

f42d355 Fixes issue with the validation message not being translated.
d859be3 Fixes a number of issues with the image uploader. Read below,
83d830f Fixes the icons not being aligned properly in attached items section for the page.
3a5c20c Removing the selected image and clearing the dropdzone on dialog close.
0335f58 Merge branch 'master' into bug/image-upload

📊 Changes

10 files changed (+48 additions, -27 deletions)

View changed files

📝 app/Http/Controllers/ImageController.php (+1 -1)
📝 app/Providers/AppServiceProvider.php (+1 -1)
📝 resources/assets/js/vues/components/dropzone.js (+13 -4)
📝 resources/assets/js/vues/image-manager.js (+3 -1)
📝 resources/assets/sass/_blocks.scss (+4 -4)
📝 resources/assets/sass/_components.scss (+16 -11)
📝 resources/assets/sass/_pages.scss (+3 -0)
📝 resources/lang/en/components.php (+2 -1)
📝 resources/lang/en/errors.php (+2 -1)
📝 resources/views/components/image-manager.blade.php (+3 -3)

📄 Description

Fixes #754

Merge request fixes the following issues,

Issues with the image validation message not being translated.
Added a remove link to remove files that have an error.
Error marker will appear above the progress bar.
Hovering on dz-image or dz-details will display the error message. Otherwise error message was covering the remove link as well.
Removed styling around the file size.
Removed gradient effect in accordance with BookStack styling.
Dropzone filename will not overflow the container element. Also done for page attachments.
Added an 'uploaded' error message. this error was being thrown when the file size exceeded the server configured file size. (https://stackoverflow.com/a/42934387/903324)
Fixes the icons not being aligned properly in attached items section for the page.
Removing the selected image and clearing the dropdzone on image manager dialog close.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/754 **Author:** [@Abijeet](https://github.com/Abijeet) **Created:** 3/18/2018 **Status:** ✅ Merged **Merged:** 3/24/2018 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `bug/image-upload` --- ### 📝 Commits (5) - [`f42d355`](https://github.com/BookStackApp/BookStack/commit/f42d355fd74fc32ea62fd85e17de304e146ca9c3) Fixes issue with the validation message not being translated. - [`d859be3`](https://github.com/BookStackApp/BookStack/commit/d859be3a128cf3a624f70cd082d3ed09124769a3) Fixes a number of issues with the image uploader. Read below, - [`83d830f`](https://github.com/BookStackApp/BookStack/commit/83d830fd7dce94ba776bb6db9356f52ef9f98092) Fixes the icons not being aligned properly in attached items section for the page. - [`3a5c20c`](https://github.com/BookStackApp/BookStack/commit/3a5c20c17e4228ad37a35e7267ab890c7ae92bcb) Removing the selected image and clearing the dropdzone on dialog close. - [`0335f58`](https://github.com/BookStackApp/BookStack/commit/0335f584783ee5a892aba751e27ce95e7b9921c3) Merge branch 'master' into bug/image-upload ### 📊 Changes **10 files changed** (+48 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/ImageController.php` (+1 -1) 📝 `app/Providers/AppServiceProvider.php` (+1 -1) 📝 `resources/assets/js/vues/components/dropzone.js` (+13 -4) 📝 `resources/assets/js/vues/image-manager.js` (+3 -1) 📝 `resources/assets/sass/_blocks.scss` (+4 -4) 📝 `resources/assets/sass/_components.scss` (+16 -11) 📝 `resources/assets/sass/_pages.scss` (+3 -0) 📝 `resources/lang/en/components.php` (+2 -1) 📝 `resources/lang/en/errors.php` (+2 -1) 📝 `resources/views/components/image-manager.blade.php` (+3 -3) </details> ### 📄 Description Fixes #754 Merge request fixes the following issues, - Issues with the image validation message not being translated. - Added a remove link to remove files that have an error. - Error marker will appear above the progress bar. - Hovering on dz-image or dz-details will display the error message. Otherwise error message was covering the remove link as well. - Removed styling around the file size. - Removed gradient effect in accordance with BookStack styling. - Dropzone filename will not overflow the container element. Also done for page attachments. - Added an 'uploaded' error message. this error was being thrown when the file size exceeded the server configured file size. (https://stackoverflow.com/a/42934387/903324) - Fixes the icons not being aligned properly in attached items section for the page. - Removing the selected image and clearing the dropdzone on image manager dialog close. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:14:45 +03:00

OVERLORD closed this issue

2026-02-05 10:14:47 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5705