[PR #651] [MERGED] Checks the target and the source book before performing the sort. #5686

New Issue

OVERLORD · 2026-02-05T10:14:10+03:00

OVERLORD commented

2026-02-05 10:14:10 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/651
Author: @Abijeet
Created: 12/31/2017
Status: ✅ Merged
Merged: 1/13/2018
Merged by: @ssddanbrown

Base: master ← Head: bug-638

📝 Commits (4)

4a24d1c Checks the target and the source book before performing the sort.
e13e71c Changed the sort view to only show books to which we have an update permission.
e269cc7 Adds test case for sorting permissions.
a77756a Refactored the code to first check for the permissions before sorting the book.

📊 Changes

4 files changed (+104 additions, -8 deletions)

View changed files

📝 app/Http/Controllers/BookController.php (+31 -2)
📝 app/Repos/EntityRepo.php (+6 -5)
📝 tests/BrowserKitTest.php (+0 -1)
📝 tests/Permissions/RestrictionsTest.php (+67 -0)

📄 Description

Fixes #638

TODO

Update the 'Books' sidebar list on the sort page to only show books the user has permission to update.
Add test cases.

Signed-off-by: Abijeet abijeetpatro@gmail.com

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/651 **Author:** [@Abijeet](https://github.com/Abijeet) **Created:** 12/31/2017 **Status:** ✅ Merged **Merged:** 1/13/2018 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `bug-638` --- ### 📝 Commits (4) - [`4a24d1c`](https://github.com/BookStackApp/BookStack/commit/4a24d1c31b7d244cb15eced098c5f8c3954f7fda) Checks the target and the source book before performing the sort. - [`e13e71c`](https://github.com/BookStackApp/BookStack/commit/e13e71cbe06f42fae43d5389ba49f86315add44b) Changed the sort view to only show books to which we have an update permission. - [`e269cc7`](https://github.com/BookStackApp/BookStack/commit/e269cc7ea71ce385fab112dcd7502fa3936582dc) Adds test case for sorting permissions. - [`a77756a`](https://github.com/BookStackApp/BookStack/commit/a77756a2dad8a0766a7220d6c6d085f321233d5f) Refactored the code to first check for the permissions before sorting the book. ### 📊 Changes **4 files changed** (+104 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/BookController.php` (+31 -2) 📝 `app/Repos/EntityRepo.php` (+6 -5) 📝 `tests/BrowserKitTest.php` (+0 -1) 📝 `tests/Permissions/RestrictionsTest.php` (+67 -0) </details> ### 📄 Description Fixes #638 ## TODO - [x] Update the 'Books' sidebar list on the sort page to only show books the user has permission to update. - [x] Add test cases. Signed-off-by: Abijeet <abijeetpatro@gmail.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:14:10 +03:00

OVERLORD closed this issue

2026-02-05 10:14:11 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5686